From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58404: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients Date: Mon, 10 Oct 2022 11:53:00 +0300 Message-ID: <83tu4cgivn.fsf@gnu.org> References: <20194da7-2318-46db-7536-bbd9e3ddf945@gmail.com> <83k058i4y2.fsf@gnu.org> <02eb7516-bccc-16ab-84f2-4688849bfba8@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8596"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58404@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 10 11:08:04 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oholY-0001xP-1B for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 11:08:04 +0200 Original-Received: from localhost ([::1]:59298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oholW-0006x2-Pd for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 05:08:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42230) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohoY1-0004EO-O3 for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 04:54:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46889) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohoXy-0006Lk-IF for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 04:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohoXy-0001D4-E2 for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 04:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Oct 2022 08:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58404 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58404-submit@debbugs.gnu.org id=B58404.16653919944546 (code B ref 58404); Mon, 10 Oct 2022 08:54:02 +0000 Original-Received: (at 58404) by debbugs.gnu.org; 10 Oct 2022 08:53:14 +0000 Original-Received: from localhost ([127.0.0.1]:45952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohoXC-0001BF-8n for submit@debbugs.gnu.org; Mon, 10 Oct 2022 04:53:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohoWx-0001AX-TL for 58404@debbugs.gnu.org; Mon, 10 Oct 2022 04:53:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45656) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohoWs-0006F8-Mu; Mon, 10 Oct 2022 04:52:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iOa9Vm5PdbKJo9UrlqewB3z3zeqgY8hvJrOUektFqEI=; b=IkWMQU277jZk 9wn8siFoqKxKPCcdvYmc3pM/f6SzGdZArZY6V8hJCzaQ7MvLSLQvFKVGcS5eA+Ne9uLbFF2Pc2A7v JacpN7a0PSGmIjddYtulWJjWZr3+nT1XF44XWjZ9DA7mywVnv3i32fDbunXriQKvdWvZCB4h0x/sY 6hmoQoQN3Ws5uxR076/FM6gvzko+rtPvA1iCvOQSuyXPPkQ+qaKmWLisUs3loxWhjhxuJJuCYrVD7 nH562JOWfnQZPYcLI19dpQVrcdTv/AdCWMp6cicbjZVgnu/Ytom//0rPAvY5iyjbtv/zpxBFuNWr7 tN86fvvFj+by8JAYDfD9XA==; Original-Received: from [87.69.77.57] (port=4004 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohoWs-0004Jr-6h; Mon, 10 Oct 2022 04:52:54 -0400 In-Reply-To: <02eb7516-bccc-16ab-84f2-4688849bfba8@gmail.com> (message from Jim Porter on Mon, 10 Oct 2022 01:08:17 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244998 Archived-At: > Date: Mon, 10 Oct 2022 01:08:17 -0700 > Cc: 58404@debbugs.gnu.org > From: Jim Porter > > On 10/9/2022 11:11 PM, Eli Zaretskii wrote: > > IMO, this is an unnecessary annoyance. We don't by default ask the > > user any questions today, when they want to kill an Emacs session. > > But Emacs *does* prompt the user today. If you call > 'save-buffers-kill-emacs' from an emacsclient frame, it will (almost) > always ask you, "This Emacs session has clients; exit anyway?" My patch > just gets rid of that annoyance when we can be sure it's unnecessary > (i.e. it won't ask if there are no other emacsclients and no other > frames not owned by a client). It is okay not to prompt when there's no need. That wasn't the part on which I commented, AFAIU. You said: > On the other hand, I think it *would* be useful to prompt if you're in > the last client, but there are other non-client frames. I'm saying that no, it will not be useful to prompt in that case: if the only frames left are non-client frames, we should not prompt, because we don't prompt when there are no client frames to begin with. Apologies if I misunderstood the use case.