From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59347: 29.0.50; `:family` face setting ignored Date: Sun, 20 Nov 2022 19:58:54 +0200 Message-ID: <83tu2t4ie9.fsf@gnu.org> References: <83bkp4bfqf.fsf@gnu.org> <83wn7s9txp.fsf@gnu.org> <83pmdk9pat.fsf@gnu.org> <83cz9j9zyu.fsf@gnu.org> <838rk77yfo.fsf@gnu.org> <834juu9aya.fsf@gnu.org> <7cc9e03786024fc72f3b@heytings.org> <83a64l65ai.fsf@gnu.org> <7cc9e0378678a092e6ee@heytings.org> <835yf962q4.fsf@gnu.org> <7cc9e03786754c9e0aaf@heytings.org> <83zgcl4jra.fsf@gnu.org> <7cc9e03786c281cffdd4@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12057"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 59347@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 20 18:59:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owobM-0002yD-C6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Nov 2022 18:59:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owoau-0002kN-EE; Sun, 20 Nov 2022 12:59:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owoas-0002jc-Mr for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 12:59:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owoas-0006fs-EH for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 12:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owoas-0003QP-AN for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 12:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Nov 2022 17:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59347 X-GNU-PR-Package: emacs Original-Received: via spool by 59347-submit@debbugs.gnu.org id=B59347.166896713213149 (code B ref 59347); Sun, 20 Nov 2022 17:59:02 +0000 Original-Received: (at 59347) by debbugs.gnu.org; 20 Nov 2022 17:58:52 +0000 Original-Received: from localhost ([127.0.0.1]:44525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owoai-0003Q0-7n for submit@debbugs.gnu.org; Sun, 20 Nov 2022 12:58:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owoah-0003Po-06 for 59347@debbugs.gnu.org; Sun, 20 Nov 2022 12:58:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owoab-0006Y5-HU; Sun, 20 Nov 2022 12:58:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=St28sz3LG2fp8cMMwTXDXKS0kz3FITPqZBOO8PtZET8=; b=sVgJ0IFCYN1e IOmY2UAO00Ul9DFufxjX+nIRi27t7ki9uncrFIcNHF+4wzD05XZBrsgdKXzOhhZ1cR4YfnrM3t3wS 4kK2QItGpxpEDPbp8enN1NYzQ7Fn6pn3NDxO76sf6BPOvwoCGoHfh8k0tpyIJK2uWkj6qIh9njo19 skOwPVpNzmtOmyS3fUbwaGLmIZsMKLV3qHN9bxF8gvyBpiv5DsEX3MdYKzIy4qtuXKxw4TtqjfijA lXZPTRPXuTP6/kEeevdK1fLnQeMNw07++hFG8NjpzFQ0Iq9gWU0UJv8N/khWkfEUzSDMdvVycCzgO 2EKnREpMMm5CQHsKNM+tlQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owoaa-0005hj-VA; Sun, 20 Nov 2022 12:58:45 -0500 In-Reply-To: <7cc9e03786c281cffdd4@heytings.org> (message from Gregory Heytings on Sun, 20 Nov 2022 17:43:23 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248445 Archived-At: > Date: Sun, 20 Nov 2022 17:43:23 +0000 > From: Gregory Heytings > cc: monnier@iro.umontreal.ca, 59347@debbugs.gnu.org > > > Does this font have a 'regular' weight? If it does, why didn't Emacs > > choose the 'regular' variant? > > Because the spec specified that it should find a medium variant. So > regular variants are rejected (because of 65fd3ca84f). No, the spec was -misc-fixed-*-r-semicondensed-*-13-*-*-*-*-*-*-*, so any weight should be okay. See Stefan's original recipe. > > In any case, I don't understand how asking for a specific foundry can > > work around the problem with weight. If you do understand that, please > > tell the details. > > I'd have to investigate this, is it really worth the effort given that a > proper fix has already been found? I'd like to hear Stefan say that this is fixed on his system as well. And yes, I'd still be interested in understanding why asking for another foundry fixed or worked around the problem. > > Yes. We need to make sure the scoring will not now sometimes prefer the > > medium weight where the regular weight exists and is a better match. > > Not only should it not reject a legitimate font, but also not prefer > > another font due to this change. IOW, the change should ideally only > > affect the cases where the 'medium' weight doesn't exist, and we > > therefore prefer to use 'regular' rather than reject the family. > > > > I don't think the case you have in mind could happen in the scenario of > this bug or bug#57555 (if a regular weight exists and is a better match > the loop in font_find_for_lface will exit with that better match), but > indeed with some other call sequence this could perhaps happen. I'll see > what I can do. Thanks, it's indeed the other cases that I worry about. We had a lot of changes in this area which solved one problem only to create others.