From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: master ef14acf: Make nnml handle invalid non-ASCII headers more consistently Date: Mon, 19 Dec 2022 19:58:25 +0200 Message-ID: <83tu1rcm2m.fsf@gnu.org> References: <20210122180801.14756.84264@vcs0.savannah.gnu.org> <20210122180802.F0A1E20A10@vcs0.savannah.gnu.org> <874jtvq8c2.fsf@oldenburg.str.redhat.com> <83k02qiicb.fsf@gnu.org> <87bko26ptd.fsf@oldenburg.str.redhat.com> <83r0wygh9b.fsf@gnu.org> <87k02nze8a.fsf@oldenburg.str.redhat.com> <83zgbjcoeq.fsf@gnu.org> <87k02ns2sg.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35691"; mail-complaints-to="usenet@ciao.gmane.io" Cc: fweimer@redhat.com, larsi@gnus.org, emacs-devel@gnu.org, ding@gnus.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 19 18:58:55 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7KPe-00094u-Sc for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Dec 2022 18:58:55 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7KP3-0007oB-LF; Mon, 19 Dec 2022 12:58:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7KP1-0007no-NW for emacs-devel@gnu.org; Mon, 19 Dec 2022 12:58:15 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7KP1-0002do-8D; Mon, 19 Dec 2022 12:58:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=QKueOsQZDvBjHJnHH69r+yi40PxkidmCoSqLq8jHTww=; b=hHnecr2fSzDOAmoFMSzb AEp29CfQCQhbcpNvsDK/JdS1jhBZmK/uOp1Wfv39GCgz2Baibn4Vk17J/9zpxngBVGeL5mDuvvdbS DhKBfRQYXM++zcNb/TzmhFfMg0UIcwFER/GY6ffb6Y7H4bcn86Anoj7wbb39BgHBYZnPPeuBv+XCR erVTZ/dMV90SOFdBrSrQYHpKzYVZ4j5n5n50gHdKXBLFzCGpGefAmWhSvuf4kQqCIT7Q17efVZ6xd tjItVNUmO0Q0VcWDBAvOo69bulphsqr4BYA8SrYAqzkaHRS7vZpdvLjQ+aguPPP1o5jLy834UXv3z Dyi7KbtV0SssFw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7KP0-00051l-Cr; Mon, 19 Dec 2022 12:58:14 -0500 In-Reply-To: <87k02ns2sg.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Mon, 19 Dec 2022 09:48:15 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301665 gmane.emacs.gnus.general:91040 Archived-At: > From: Eric Abrahamsen > Cc: Florian Weimer , larsi@gnus.org, > emacs-devel@gnu.org, ding@gnus.org > Date: Mon, 19 Dec 2022 09:48:15 -0800 > > On 12/19/22 19:07 PM, Eli Zaretskii wrote: > >> Going back to older mail, I see that previously the From: header was > >> written in encoded form to .overview (slightly wrapped to avoid SMTP > >> issues): > >> > >> 8523 Re: [PATCH 1/7] Rename 'hello2.spec.' -> 'hello2.spec' > >> 'hello3.spec.' -> 'hello3.spec' > >> =?utf-8?b?572X5YuH5YiaKFlvbmdnYW5nIEx1bykgdmlhIEVsZnV0aWxzLWRldmVs?= > >> Thu, 24 Nov 2022 16:27:56 +0800 > >> > >> <20220920084307.1696-1-luoyonggang@gmail.com> > >> <20220920084307.1696-2-luoyonggang@gmail.com> > >> > >> > >> <20221019194930.GC24703@redhat.com> > >> <3bf19d05c8976411432709fae1cc2bcc2d21d700.camel@klomp.org> > >> <586fbfd512763e539f0d06e8ffa308da34be5368.camel@wildebeest.org> > >> 705 32 Xref: oldenburg.str.redhat.com > >> lists.sourceware.elfutils-devel:8523 Cc: "Frank Ch. Eigler" > >> , elfutils-devel@sourceware.org To: Mark Wielaard > >> > >> > >> Now it uses unencoded form: > >> > >> 8762 Re: [PATCH v2 13/16] lib: isatty is not available on windows 罗 > >> 勇刚(Yonggang Luo) via Elfutils-devel > >> Mon, 19 Dec 2022 20:32:48 +0800 > >> > >> <20221217165213.152-1-luoyonggang@gmail.com> > >> <20221217165213.152-14-luoyonggang@gmail.com> 1074 43 Xref: > >> oldenburg.str.redhat.com lists.sourceware.elfutils-devel:8762 To: > >> elfutils-devel@sourceware.org > > > > Is that a problem? I think this was part of the reason for that > > change in nnml.el. > > It would definitely be a problem to change the on-disk representation of > data in the .overview files! Lots of code depends on a very specific > format for those files; I've broken things badly in the past by removing > header encoding there. But this change is there since Emacs 28, so if it's a problem, someone would have hollered already, no? Or are you saying that the changes I installed are causing the difference? If so, I don't see how that could happen, since the change just ignores any errors signaled by rfc2047, and if rfc2047 does signal an error, what is stored in the file is the same string as what we did before the new function nnml--encode-headers was added and we started using it. So unless I'm missing something, the changes I installed cannot cause any new problems we didn't have since quite long ago.