From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60484: 29.0.60; c-ts-mode: short tokens are not identified as type_identifier Date: Mon, 02 Jan 2023 14:45:58 +0200 Message-ID: <83tu1914vt.fsf@gnu.org> References: <677a429cb107ff200396e0c59eefecda@sadiqpk.org> <83358t2kv1.fsf@gnu.org> <1d2f9bd1c64ed11124a0129b0ae8b672@sadiqpk.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34768"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60484@debbugs.gnu.org To: Mohammed Sadiq Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 02 13:46:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCKCo-0008kK-AC for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Jan 2023 13:46:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCKCa-00021H-21; Mon, 02 Jan 2023 07:46:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCKCY-0001zX-DL for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 07:46:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pCKCY-0004OL-63 for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 07:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pCKCX-0001nf-UN for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 07:46:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Jan 2023 12:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60484 X-GNU-PR-Package: emacs Original-Received: via spool by 60484-submit@debbugs.gnu.org id=B60484.16726635596911 (code B ref 60484); Mon, 02 Jan 2023 12:46:01 +0000 Original-Received: (at 60484) by debbugs.gnu.org; 2 Jan 2023 12:45:59 +0000 Original-Received: from localhost ([127.0.0.1]:42688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCKCU-0001nP-WB for submit@debbugs.gnu.org; Mon, 02 Jan 2023 07:45:59 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCKCT-0001gD-Q5 for 60484@debbugs.gnu.org; Mon, 02 Jan 2023 07:45:58 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCKCN-0004O7-7z; Mon, 02 Jan 2023 07:45:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=U5aFyamKwosJvBCdTIFx75t4cxdtTixI8NoT55uiWjA=; b=ER8BQmcpZ2jN yPo/FQL3GJrrA45ee2BSZR7MdbvopEnlHGylA6mXj3L96h9AnS/ayfkf3nyjMX/juj5BDQTn8BGnA UEbZnnZsKp28jItBnSE5x9PfLlyPRA29K3uz0nIq7umUco/tNaPKqiyaauhQLhpXDC7/23VX1+ndh VRcW3U7tlD0NeH8krDdLIgLM+9cWPoQJGOMcBjtu+GKGARN5LjwoWGQ8mJEiK47/kkzFjlTkD9EBu BHQH33Dc6MUmGAR4TjOmumEPbexVrphaxLuuWYHIWjZWiDQtaMs/ob3certnjicQCL7rG0jVjo+tf Gg1ZvMjeL8kKPi6zhRFnHQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCKCM-0000ym-EW; Mon, 02 Jan 2023 07:45:50 -0500 In-Reply-To: <1d2f9bd1c64ed11124a0129b0ae8b672@sadiqpk.org> (message from Mohammed Sadiq on Mon, 02 Jan 2023 18:13:34 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252334 Archived-At: > Date: Mon, 02 Jan 2023 18:13:34 +0530 > From: Mohammed Sadiq > Cc: 60484@debbugs.gnu.org > > On 2023-01-02 17:45, Eli Zaretskii wrote: > >> Date: Mon, 02 Jan 2023 10:22:09 +0530 > >> From: Mohammed Sadiq > >> > >> Short tokens are not identified as type_identifier in GNU Emacs > >> c-ts-mode, but does work fine with tree-sitter playground[0]. > >> > >> Say for example, 'a_type' in an empty buffer is identified as a > >> type_identifier in tree-sitter playground, but not in c-ts-mode, > >> while say, some longer tokens like 'window_type' is identified as > >> type_identifier. > > > > Where is it written that FOO_type is a type identifier? is this > > something new in some recent C Standard? Or is it just a popular > > convention? > > 'a_type' was just a made up example, it can be any valid token, say > 'g_file', or whatever. I was pointing out a disparity in handling of > some token in c-ts-mode and tree-sitter: tree-sitter identifiers a 6 > byte length token as an identifier, but c-ts-mode requires it to be > at least 11 byte sized for custom types. I'm not sure I see a problem here. It sounds like different heuristics to me. Nothing says that g_file is a type, only its parsing can tell.