all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: 61639@debbugs.gnu.org
Subject: bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired
Date: Tue, 21 Feb 2023 14:01:34 +0200	[thread overview]
Message-ID: <83ttzfteg1.fsf@gnu.org> (raw)
In-Reply-To: <87bklothkw.fsf@ledu-giraud.fr> (message from Manuel Giraud on Mon, 20 Feb 2023 17:41:35 +0100)

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 61639@debbugs.gnu.org
> Date: Mon, 20 Feb 2023 17:41:35 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I don't necessarily see a reason to alert the user in this case, but
> > if you think we had better done that, we could show a message when we
> > find a non-image file in the list of the selected ones.
> 
> Ok.  Here is a new version of the patch that address those issues.  I
> choose to not alert the user.

Thanks.  This LGTM, but what is 'plusp'?

> diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el
> index cfcd1851188..5798af77f35 100644
> --- a/lisp/image/image-dired.el
> +++ b/lisp/image/image-dired.el
> @@ -586,13 +586,15 @@ image-dired-display-thumbs
>                (erase-buffer))
>            (goto-char (point-max)))
>          (dolist (file files)
> -          (let ((thumb (image-dired--get-create-thumbnail-file file)))
> +          (when (string-match-p (image-dired--file-name-regexp) file)
>              (image-dired-insert-thumbnail
> -             thumb file dired-buf
> +             (image-dired--get-create-thumbnail-file file) file dired-buf
>               (cl-incf image-dired--number-of-thumbnails)))))
> -      (if do-not-pop
> -          (display-buffer buf)
> -        (pop-to-buffer buf))
> +      (if (plusp image-dired--number-of-thumbnails)  <<<<<<<<<<<<<<<<<<<<<<
> +          (if do-not-pop
> +              (display-buffer buf)
> +            (pop-to-buffer buf))
> +        (message "No images selected"))
>        (image-dired--line-up-with-method)
>        (image-dired--update-header-line))))





  reply	other threads:[~2023-02-21 12:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-19 20:09 bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 12:49 ` Eli Zaretskii
2023-02-20 13:35   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 13:46     ` Eli Zaretskii
2023-02-20 14:13       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 14:45         ` Eli Zaretskii
2023-02-20 16:41           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-21 12:01             ` Eli Zaretskii [this message]
2023-02-21 12:16               ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-21 13:03                 ` Eli Zaretskii
2023-02-21 14:23                   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-22 13:22                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ttzfteg1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=61639@debbugs.gnu.org \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.