From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62300: 29.0.60; No hyperlinks for some symbols in *Help* buffers Date: Mon, 20 Mar 2023 20:52:28 +0200 Message-ID: <83ttyf6ys3.fsf@gnu.org> References: <83y1nr6zmr.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29355"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62300@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 20 19:53:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1peKdA-0007SC-Ta for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Mar 2023 19:53:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peKcz-0006qo-G9; Mon, 20 Mar 2023 14:53:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peKcx-0006qX-J4 for bug-gnu-emacs@gnu.org; Mon, 20 Mar 2023 14:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peKcx-0007x3-9U for bug-gnu-emacs@gnu.org; Mon, 20 Mar 2023 14:53:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1peKcw-0002KO-KK for bug-gnu-emacs@gnu.org; Mon, 20 Mar 2023 14:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Mar 2023 18:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62300 X-GNU-PR-Package: emacs Original-Received: via spool by 62300-submit@debbugs.gnu.org id=B62300.16793383478905 (code B ref 62300); Mon, 20 Mar 2023 18:53:02 +0000 Original-Received: (at 62300) by debbugs.gnu.org; 20 Mar 2023 18:52:27 +0000 Original-Received: from localhost ([127.0.0.1]:56825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peKcM-0002JY-L0 for submit@debbugs.gnu.org; Mon, 20 Mar 2023 14:52:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peKcK-0002JL-IA for 62300@debbugs.gnu.org; Mon, 20 Mar 2023 14:52:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peKcF-0007oY-7b; Mon, 20 Mar 2023 14:52:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7EAVQoYkQUE4XnPV+/+yFXbtj45ANfn5V+WZ99qK2gA=; b=H4MKrd2S1I1k yaXQMuQ9SIc40ttdO7JBePxz3Bxd+3Ogg3xHKb0Mvu15lDVFEWFHrwMl7NS/T2zzDVV2jia0S3IrX 5AD8t5jI0fx2t5xuznA3CWnceDdzm90Cdu1KhPcHNxNY+hseQpMu8RFOrGiTOydjrt/P5Z8CjEQni sUHm3Q/+EP9cFgQGNb5wdopxgTUKC8S2J2cu3/UsyggoQTa7Fse/yI8cT5pWtp2M2lMW4nnjWL/xI XILtpBlCfsl0yrR5+hic3+aZyotmiLO/ui5OxrOLEzl+c9LJYrV0ya2nCpVS/YVnXWowALXydd1Fc vFjDWidsy9iowSBdW7TfuQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peKcE-0006Lb-No; Mon, 20 Mar 2023 14:52:19 -0400 In-Reply-To: <83y1nr6zmr.fsf@gnu.org> (message from Eli Zaretskii on Mon, 20 Mar 2023 20:34:04 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258316 Archived-At: > Date: Mon, 20 Mar 2023 20:34:04 +0200 > From: Eli Zaretskii > > To reproduce: > > emacs -Q > C-h f global-text-scale-adjust RET > > Observe that in the *Help* buffer the variable > global-text-scale-adjust-resizes-frames does not have the link > appearance. This is because: > > (boundp 'global-text-scale-adjust-resizes-frames) => nil > > By contrast, if you try > > C-h f text-scale-adjust RET > > then the variable text-scale-mode-step in the *Help* buffer does get > the link appearance, and boundp returns non-nil for that variable. > > The reason seems to be that in the latter case typing the "C-h f" > command causes face-remap.el to be loaded, whereas in the former case > face-remap.el is not loaded. I traced that to a problem which can be > demonstrated by the following recipe: > > emacs -Q > M-x load-library RET help-fns RET > > Now evaluate: > > (radix-tree-prefixes (help-definition-prefixes) "global-text-scale-adjust") > > This returns nil, whereas if you do the same with "text-scale-adjust", > you get: > > (("text-scale-" "face-remap") ("tex" "flyspell")) > > Interestingly, just appending a dash to global-text-scale-adjust, i.e. > > (radix-tree-prefixes (help-definition-prefixes) "global-text-scale-adjust-") > > does yield non-nil result: > > (("global-text-scale-adjust-" "face-remap")) > > The non-nil result causes help-fns.el:help--symbol-completion-table to > load the file: > > (when help-enable-completion-autoload > (let ((prefixes (radix-tree-prefixes (help-definition-prefixes) string))) > (help--load-prefixes prefixes))) > > The load happens inside help--load-prefixes. As result face-remap.el > is loaded for text-scale-adjust, and the variables defined in > face-remap.el become defined. With global-text-scale-adjust the > loading doesn't happen, and the variable stays unbound. > > This sounds like some snafu with some heuristic somewhere, perhaps in > radix-tree-prefixes, or in the code which registers the prefixes to > begin with? > > Can this be fixed, please, so that variables referenced in doc strings > would reliably be displayed as links? Adding Stefan. Stefan, any suggestions or ideas?