From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62502: 29.0.60; Docstring of `read-char-choice' Date: Tue, 28 Mar 2023 20:29:11 +0300 Message-ID: <83tty47pjs.fsf@gnu.org> References: <86tty52bgq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40786"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62502@debbugs.gnu.org To: Arash Esbati Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 28 19:30:39 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phD9a-000APD-Sx for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Mar 2023 19:30:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phD93-0004D1-2l; Tue, 28 Mar 2023 13:30:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phD91-0004Cp-DE for bug-gnu-emacs@gnu.org; Tue, 28 Mar 2023 13:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1phD91-0002O6-3g for bug-gnu-emacs@gnu.org; Tue, 28 Mar 2023 13:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1phD90-0001a2-RJ for bug-gnu-emacs@gnu.org; Tue, 28 Mar 2023 13:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Mar 2023 17:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62502 X-GNU-PR-Package: emacs Original-Received: via spool by 62502-submit@debbugs.gnu.org id=B62502.16800245565967 (code B ref 62502); Tue, 28 Mar 2023 17:30:02 +0000 Original-Received: (at 62502) by debbugs.gnu.org; 28 Mar 2023 17:29:16 +0000 Original-Received: from localhost ([127.0.0.1]:50649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phD8F-0001YB-PB for submit@debbugs.gnu.org; Tue, 28 Mar 2023 13:29:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phD8E-0001Xv-Ay for 62502@debbugs.gnu.org; Tue, 28 Mar 2023 13:29:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phD89-000268-01 for 62502@debbugs.gnu.org; Tue, 28 Mar 2023 13:29:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=7CBXvq9FtlHbDJtcSvNcux+Nhz+VT6Yje6tqclk3aLM=; b=Ch6/WeMVEgACyhN4IJN/ DTQFw8gGpQtANGF+CxmFNLxj+RSXv62v7ynDHOXzSWvU7PimkL9hKkyoWTeVK0XEHp3HhWgx4pJ9c 9ddw/m1LJYrBOKrMeHLFEMtwGtQIqJN1/j5OPeASnaOOQ/YGz+D+nzuB7iTUvJD6cV08EZwboQDyi l2btRA6DleN6AJ45uonKze77mRr8OfTTdkJ0ptn9DRsouOufYD+GGBf15Yv5hSSH9s047EqvnF2Do FX0yDjlANm0qdSDVB7a7GQiH1hbedWPkF2HrGsYiCZPrwS7pZP/t7BVt7nId0nzj+Cq0xu/pQk5TZ A0sJWXkiUHoCng==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phD86-000326-Dw; Tue, 28 Mar 2023 13:29:07 -0400 In-Reply-To: <86tty52bgq.fsf@gnu.org> (message from Arash Esbati on Tue, 28 Mar 2023 16:32:21 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258817 Archived-At: > From: Arash Esbati > Date: Tue, 28 Mar 2023 16:32:21 +0200 > > docstring of `read-char-choice' lacks any information about > INHIBIT-KEYBOARD-QUIT: That's because by default that argument is ignored. > INHIBIT-KEYBOARD-QUIT is passed to `read-char-choice-with-read-key'; I'd > say it is sufficient to say something like: > > If ‘read-char-choice-use-read-key’ is non-nil, the modal ‘read-key’ > function is used instead (see ‘read-char-choice-with-read-key’) and > the optional INHIBIT-KEYBOARD-QUIT is passed to it. Is it really useful? I believe read-char-choice-with-read-key is kept for possible backward compatibility; new Lisp programs that want to use read-char-choice-with-read-key should just call it directly, and in its doc string this argument is documented. So I'm not sure we should do anything about this issue.