From: Eli Zaretskii <eliz@gnu.org>
To: casouri@gmail.com
Cc: luangruo@yahoo.com, emacs-devel@gnu.org
Subject: Re: master 67ab357cdcc 7/7: Support treesit-thing-settings in search functions
Date: Sat, 15 Apr 2023 12:58:15 +0300 [thread overview]
Message-ID: <83ttxhcvrc.fsf@gnu.org> (raw)
In-Reply-To: <83mt39einy.fsf@gnu.org> (message from Eli Zaretskii on Sat, 15 Apr 2023 09:58:09 +0300)
> Date: Sat, 15 Apr 2023 09:58:09 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org, casouri@gmail.com
>
> > From: Po Lu <luangruo@yahoo.com>
> > Cc: Yuan Fu <casouri@gmail.com>
> > Date: Sat, 15 Apr 2023 10:43:21 +0800
> >
> > Yuan Fu <casouri@gmail.com> writes:
> >
> > > +/* Assq but doesn't signal. */
> > > +static Lisp_Object
> > > +safe_assq (Lisp_Object key, Lisp_Object alist)
> > > +{
> > > + Lisp_Object tail = alist;
> > > + FOR_EACH_TAIL_SAFE (tail)
> > > + if (CONSP (XCAR (tail)) && EQ (XCAR (XCAR (tail)), key))
> > > + return XCAR (tail);
> > > + return Qnil;
> > > +}
> >
> > Please, write more descriptive doc strings. I would write:
> >
> > /* Like `assq_no_quit', except it avoids chasing after circular
> > lists. */
>
> It is more efficient to just go ahead and make minor changes like
> that, than start discussions about them.
Btw, Yuan: any reason you couldn't use the existing assq_no_quit here?
next prev parent reply other threads:[~2023-04-15 9:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168151708682.12577.9938116109918336537@vcs2.savannah.gnu.org>
[not found] ` <20230415000448.67F57C13A82@vcs2.savannah.gnu.org>
2023-04-15 2:43 ` master 67ab357cdcc 7/7: Support treesit-thing-settings in search functions Po Lu
2023-04-15 6:58 ` Eli Zaretskii
2023-04-15 9:58 ` Eli Zaretskii [this message]
2023-04-16 5:54 ` Yuan Fu
2023-04-16 6:37 ` Eli Zaretskii
2023-04-16 6:42 ` Yuan Fu
2023-04-16 8:19 ` Eli Zaretskii
2023-04-17 3:37 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ttxhcvrc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.