From: Eli Zaretskii <eliz@gnu.org>
To: gongqijian@gmail.com
Cc: 64395@debbugs.gnu.org
Subject: bug#64395: [PATCH] * src/xdisp.c (display_string): Don't truncate mode line in terminal
Date: Sat, 01 Jul 2023 15:47:39 +0300 [thread overview]
Message-ID: <83ttunpzmc.fsf@gnu.org> (raw)
In-Reply-To: <83wmzjq1sf.fsf@gnu.org> (message from Eli Zaretskii on Sat, 01 Jul 2023 15:00:48 +0300)
> Cc: 64395@debbugs.gnu.org
> Date: Sat, 01 Jul 2023 15:00:48 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > From: qijian gong <gongqijian@gmail.com>
> > Date: Sat, 1 Jul 2023 19:25:26 +0800
> > Cc: 64395@debbugs.gnu.org
> >
> > The picture I sent earlier is an animation. It shows the entire reproduction process and the result.
>
> Sorry, I didn't realize that it included animation.
>
> I think I see the issue now.
OK, I've now found a way of reproducing the problem on a system to
which I have access.
Your proposed change fixes the problem, but it fixes it incorrectly:
after applying the patch, I see a truncation glyph "$" at the end of
the mode line. This should never happen on the mode line: we don't
show truncation glyphs there. Compare the display after applying your
patch with the mode-line displayed after evaluating the below:
(setq mode-line-format
(concat (format-mode-line
"- Ln %l, Col %c ")
(make-string 100 ?-)))
As you see, the expected display of the mode line that is truncated is
simply not to see the truncated part, without any "$" truncation
glyph at the end of the mode line.
So a slightly different change is needed to properly fix this case.
I'm working on such a proper fix.
next prev parent reply other threads:[~2023-07-01 12:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-01 6:27 bug#64395: [PATCH] * src/xdisp.c (display_string): Don't truncate mode line in terminal Gong Qijian
2023-07-01 7:50 ` Eli Zaretskii
[not found] ` <CAPWNH1M1eOtjxP0M0dckXk94FYKGqQxSb8NKb4XUzddggWREMw@mail.gmail.com>
2023-07-01 10:42 ` Eli Zaretskii
2023-07-01 10:45 ` qijian gong
2023-07-01 10:50 ` Eli Zaretskii
2023-07-01 11:00 ` qijian gong
2023-07-01 11:07 ` Eli Zaretskii
2023-07-01 11:25 ` qijian gong
2023-07-01 12:00 ` Eli Zaretskii
2023-07-01 12:47 ` Eli Zaretskii [this message]
2023-07-02 8:15 ` Eli Zaretskii
2023-07-15 7:47 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ttunpzmc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64395@debbugs.gnu.org \
--cc=gongqijian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.