From: Eli Zaretskii <eliz@gnu.org>
To: Morgan Smith <Morgan.J.Smith@outlook.com>
Cc: jao@gnu.org, 64516@debbugs.gnu.org, tsdh@gnu.org
Subject: bug#64516: [PATCH] docview: Only enable imenu when supported
Date: Sat, 15 Jul 2023 11:05:11 +0300 [thread overview]
Message-ID: <83ttu5d2h4.fsf@gnu.org> (raw)
In-Reply-To: <DM5PR03MB3163020801BFC39F82EEEDC7C531A@DM5PR03MB3163.namprd03.prod.outlook.com> (message from Morgan Smith on Tue, 11 Jul 2023 14:22:49 -0400)
> From: Morgan Smith <Morgan.J.Smith@outlook.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, 64516@debbugs.gnu.org, jao@gnu.org
> Date: Tue, 11 Jul 2023 14:22:49 -0400
>
> I apologize for my "oops I figured it out immediately after I sent the
> email" syndrome. I was trying to find the answer in the bug reports
> when the answer was in the code and quite obvious.
>
> Anyways here is a patch that unconditionally enables imenu but checks
> the return value of mutool and will raise an imenu-unavailable-error
> when it is not successful. However, that error stops docview from
> displaying the document so I decided to put the setup function in a hook
> so the error occurs after the document is displayed.
>
> I looked briefly for documentation on how errors work in hooks but could
> not find any. I don't want this error to prevent the other hooks from
> being run (which would be user defined hooks. we don't currently use
> this hook).
Tassilo, is this okay, in your opinion?
next prev parent reply other threads:[~2023-07-15 8:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 15:24 bug#64516: [PATCH] docview: Only enable imenu when supported Morgan Smith
2023-07-07 15:40 ` Morgan Smith
2023-07-07 16:05 ` Morgan Smith
2023-07-08 9:14 ` Eli Zaretskii
2023-07-09 8:13 ` Tassilo Horn
2023-07-11 17:49 ` Morgan Smith
2023-07-11 18:22 ` Morgan Smith
2023-07-15 8:05 ` Eli Zaretskii [this message]
2023-07-15 18:39 ` Tassilo Horn
2023-07-15 23:50 ` Morgan Smith
2023-07-16 4:39 ` Tassilo Horn
2023-07-16 15:03 ` Morgan Smith
2023-07-16 15:24 ` Tassilo Horn
2023-07-18 18:40 ` Morgan Smith
2023-07-18 19:14 ` Tassilo Horn
2023-07-20 16:05 ` Eli Zaretskii
2023-07-28 10:14 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-28 10:19 ` Tassilo Horn
2023-07-28 11:22 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-11 18:28 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ttu5d2h4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64516@debbugs.gnu.org \
--cc=Morgan.J.Smith@outlook.com \
--cc=jao@gnu.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.