From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64927: 30.0.50; kill-ring with no X Date: Thu, 03 Aug 2023 21:26:47 +0300 Message-ID: <83tttgvv6g.fsf@gnu.org> References: <87edkrdp78.fsf@yandex.com> <87a5vfdko3.fsf@yandex.com> <838rasxxlw.fsf@gnu.org> <83y1isw1yl.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15909"; mail-complaints-to="usenet@ciao.gmane.io" Cc: m43cap@yandex.com, larsi@gnus.org, 64927@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 03 20:27:42 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRd2z-0003s6-Sx for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Aug 2023 20:27:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRd2O-0006x5-63; Thu, 03 Aug 2023 14:27:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRd2M-0006we-FP for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 14:27:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRd2M-0007Zk-7N for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 14:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRd2L-0005RV-QC for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 14:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Aug 2023 18:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64927 X-GNU-PR-Package: emacs Original-Received: via spool by 64927-submit@debbugs.gnu.org id=B64927.169108720620900 (code B ref 64927); Thu, 03 Aug 2023 18:27:01 +0000 Original-Received: (at 64927) by debbugs.gnu.org; 3 Aug 2023 18:26:46 +0000 Original-Received: from localhost ([127.0.0.1]:52914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRd26-0005R2-5M for submit@debbugs.gnu.org; Thu, 03 Aug 2023 14:26:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRd24-0005Qo-9Z for 64927@debbugs.gnu.org; Thu, 03 Aug 2023 14:26:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRd1x-0007Tq-V3; Thu, 03 Aug 2023 14:26:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ENcmT/A+A1aAXshPCndN9/KI9pyKFuLkGY93Z0Bibd8=; b=aSSuQUcpfVJf y1A72Yc9ED2xXA6fE7C81Q97OIkSG9Oxq60YJHuEYW4bfn82OjV+NLJ0pfkiuJVav/MnbmYEtfxsR QxC9w/Uu4i9BsmlpaZUdvm6Pl3ZLj78zBI7bj3ItygMCCYJEc+FQgCSnquxD234a636ZaL/2JAVv9 JioXVv9MhhpGPNVF/gwHzLO4JeZBL/+AYJkG2iclia51rIBCd/we4Ib5hIzPdJdiZExgsibvs/u43 mK85H4fdhwbK3NZCiNFBjyQ9W7cCq9B2WjTj1nOxHt6eRTn1gO1iiiAOViYqEL2XWMenIAkl+5rG8 ft3Oql+MHKhKY8kIW4SRag==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRd1x-0002OV-25; Thu, 03 Aug 2023 14:26:37 -0400 In-Reply-To: (message from Stefan Monnier on Thu, 03 Aug 2023 12:30:36 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266616 Archived-At: > From: Stefan Monnier > Cc: m43cap@yandex.com, 64927@debbugs.gnu.org, larsi@gnus.org > Date: Thu, 03 Aug 2023 12:30:36 -0400 > > I think this problem was noticed when the new feature was introduced and > we fixed the generation of the kill-ring menu, but apparently nobody > fixed the problem in the second part of the code which generates the > kill-ring (I remember I mentioned at the time that we should try and > consolidate those two code paths). Looks like that, yes. > > Do you see any reasonably practical way to get that back? > > The best we can do is to use `key-valid-p` as a best-effort test to > decide whether we're in the presence of the new or the old format, but > it will inevitably suffer from false positives/negatives. Not sure I understand: if key-valid-p returns nil, what do you suggest to do with "keys" such as those produced in the scenario of this bug report?