From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported Date: Thu, 10 Aug 2023 08:17:41 +0300 Message-ID: <83ttt7jx1m.fsf@gnu.org> References: <4b873c29-e8ca-403c-bd37-a531d93661f3@lucaswerkmeister.de> <83fs4tmlik.fsf@gnu.org> <83cyzxmj1g.fsf@gnu.org> <63a54bee-6bfd-70e5-a9b5-a6f650cabd12@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13344"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 65156@debbugs.gnu.org, mail@lucaswerkmeister.de To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 10 07:18:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qTy46-0003G3-IV for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Aug 2023 07:18:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qTy3g-0007Hb-3B; Thu, 10 Aug 2023 01:18:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTy3e-0007HQ-Qv for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 01:18:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qTy3e-0001oD-Gz for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 01:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qTy3e-0007z7-D6 for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 01:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Aug 2023 05:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65156 X-GNU-PR-Package: emacs Original-Received: via spool by 65156-submit@debbugs.gnu.org id=B65156.169164464630641 (code B ref 65156); Thu, 10 Aug 2023 05:18:02 +0000 Original-Received: (at 65156) by debbugs.gnu.org; 10 Aug 2023 05:17:26 +0000 Original-Received: from localhost ([127.0.0.1]:41011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTy33-0007y8-Re for submit@debbugs.gnu.org; Thu, 10 Aug 2023 01:17:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTy31-0007xt-3Z for 65156@debbugs.gnu.org; Thu, 10 Aug 2023 01:17:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTy2u-0001fK-BX; Thu, 10 Aug 2023 01:17:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ww4T0Ycm/YbShZYHisIAdS7UKXfpQijcRLO8NKjaALg=; b=BpVi3XWLflvZZ+FU6cKn cggoQ08vIVPAY18jndzV68u/xzhyZlXciiSftuqgC+fuFEPRIruSq6rLI00phz8UvzrFmX3hCjrxy e0FF1Zv40UYKOAZRR+EkdYIN49ETNTcV2Y41TC+LhB/4AqXn5uuZUB5rKrs9NqTRug9d9iK6Kr8Gw 3BQnyTl1A+hbmd0INR1s3+0ZN6t9byWbSe14RmmbiBy5oxIwIEe4YQTgBUrt41xJR+ZSAv1rNiBeE TvOjkHv7884VvRvJPQ+DA3Q4+8gxL69Fh4TF9Hksam9RMW/KZ/sYR0jfaRk385AUznzjVczpiK01c 3LGOPOhy1HoIrw==; In-Reply-To: <63a54bee-6bfd-70e5-a9b5-a6f650cabd12@cs.ucla.edu> (message from Paul Eggert on Wed, 9 Aug 2023 13:57:36 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267081 Archived-At: > Date: Wed, 9 Aug 2023 13:57:36 -0700 > Cc: larsi@gnus.org, 65156@debbugs.gnu.org > From: Paul Eggert > > On 2023-08-08 12:27, Eli Zaretskii wrote: > > Paul, can there be a regular file that is not seekable? > > No. Thanks. This is no longer an issue, though. > The current code on master is a bit of a mess. There's nothing wrong > with using a positive BEG on a seekable and non-regular file, for > example; the old doc string was wrong and now the code has been changed > to match the doc string unfortunately. Nor is there anything wrong if > BEG is 0 on a non-seekable file (though this latter issue is > longstanding and so I guess nobody cares). These are minor issues that should be easy to clean up, I think? If so, now is a good time for doing that on master. > There are surely some gotchas involving the REPLACE arg of > insert-file-contents too, but it's hard to tell because the doc string > seems to be corrupted for the case where REPLACE is 'if-regular' and I > don't know what it's trying to say. I guess you are alluding to this part: If REPLACE is the symbol ‘if-regular’, then eschew preserving marker positions or the undo list if REPLACE is nil if FILENAME is not a regular file. Otherwise, signal an error if REPLACE is non-nil and FILENAME is not a regular file. Which part(s) of this are unclear?