all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: larsi@gnus.org, 65156@debbugs.gnu.org, mail@lucaswerkmeister.de
Subject: bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported
Date: Thu, 10 Aug 2023 08:17:41 +0300	[thread overview]
Message-ID: <83ttt7jx1m.fsf@gnu.org> (raw)
In-Reply-To: <63a54bee-6bfd-70e5-a9b5-a6f650cabd12@cs.ucla.edu> (message from Paul Eggert on Wed, 9 Aug 2023 13:57:36 -0700)

> Date: Wed, 9 Aug 2023 13:57:36 -0700
> Cc: larsi@gnus.org, 65156@debbugs.gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> 
> On 2023-08-08 12:27, Eli Zaretskii wrote:
> > Paul, can there be a regular file that is not seekable?
> 
> No.

Thanks.  This is no longer an issue, though.

> The current code on master is a bit of a mess. There's nothing wrong 
> with using a positive BEG on a seekable and non-regular file, for 
> example; the old doc string was wrong and now the code has been changed 
> to match the doc string unfortunately. Nor is there anything wrong if 
> BEG is 0 on a non-seekable file (though this latter issue is 
> longstanding and so I guess nobody cares).

These are minor issues that should be easy to clean up, I think?  If
so, now is a good time for doing that on master.

> There are surely some gotchas involving the REPLACE arg of 
> insert-file-contents too, but it's hard to tell because the doc string 
> seems to be corrupted for the case where REPLACE is 'if-regular' and I 
> don't know what it's trying to say.

I guess you are alluding to this part:

  If REPLACE is the symbol ‘if-regular’, then eschew preserving marker
  positions or the undo list if REPLACE is nil if FILENAME is not a
  regular file.  Otherwise, signal an error if REPLACE is non-nil and
  FILENAME is not a regular file.

Which part(s) of this are unclear?





  reply	other threads:[~2023-08-10  5:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 18:20 bug#65156: 29.1; Reading from pipe with --insert or insert-file-contents no longer supported Lucas Werkmeister
2023-08-08 18:33 ` Eli Zaretskii
2023-08-08 19:27   ` Eli Zaretskii
2023-08-09  2:47     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-09 11:31       ` Eli Zaretskii
2023-08-09 20:57     ` Paul Eggert
2023-08-10  5:17       ` Eli Zaretskii [this message]
2023-08-10  6:08         ` Paul Eggert
2023-08-10  8:15           ` Eli Zaretskii
2023-08-11 17:18             ` Paul Eggert
2023-08-11 18:30               ` Eli Zaretskii
2023-08-11 21:45                 ` Paul Eggert
2023-08-12  8:05                   ` Eli Zaretskii
2023-08-12  8:58                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-09  8:07 ` Mattias Engdegård
2023-08-09  8:15   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-09  8:29     ` Mattias Engdegård
2023-08-09 12:00       ` Eli Zaretskii
2023-08-09 12:03         ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ttt7jx1m.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=65156@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=larsi@gnus.org \
    --cc=mail@lucaswerkmeister.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.