From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching Date: Thu, 07 Sep 2023 11:59:37 +0300 Message-ID: <83tts6z7d2.fsf@gnu.org> References: <127B5BEA-A24B-48A3-9827-85B7CDB67D10@secure.kjonigsen.net> <5f823f8f-d249-f4a1-71e6-083e47d0d123@gutov.dev> <83jztbeeh2.fsf@gnu.org> <03415a27-f082-b204-cece-19a9859e178d@gutov.dev> <8334zze5l4.fsf@gnu.org> <1363c54f-5109-f000-3333-78d291b2096d@gutov.dev> <2D516F0C-D7A8-49D2-8009-F911EFC55C78@secure.kjonigsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14123"; mail-complaints-to="usenet@ciao.gmane.io" Cc: btuin@mailo.com, dmitry@gutov.dev, casouri@gmail.com, 65470@debbugs.gnu.org, theo@thornhill.no To: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 07 11:00:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeAsO-0003US-NC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Sep 2023 11:00:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeArt-0007UQ-6b; Thu, 07 Sep 2023 05:00:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeArq-0007SF-2D for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 05:00:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeArp-0008U4-Nj for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 05:00:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeArq-0000Ta-Sc for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 05:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Sep 2023 09:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65470 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65470-submit@debbugs.gnu.org id=B65470.16940772001793 (code B ref 65470); Thu, 07 Sep 2023 09:00:02 +0000 Original-Received: (at 65470) by debbugs.gnu.org; 7 Sep 2023 09:00:00 +0000 Original-Received: from localhost ([127.0.0.1]:38557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeAro-0000Sr-0F for submit@debbugs.gnu.org; Thu, 07 Sep 2023 05:00:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeArm-0000Sc-2w for 65470@debbugs.gnu.org; Thu, 07 Sep 2023 04:59:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeArd-0008SC-S7; Thu, 07 Sep 2023 04:59:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=uQHsj1z4KShlhPT2rJFApf+ZXFB5tupoJrhwc9O+UVo=; b=BTDkAUrn8kctpn541s7B a2QHSCaMRlu6vroAGFAMcI6OF3Y9+J7JgBWXkFrzoa+RWcYRAtXseGbrhVR6RYWoC3f432dS3e0AB ypoLgJJeXDbE09wTKGCGiWhOyer6XKsFH93bagEF/SkBBP80HZ3bdsdHEoxhsVAg6ja2hpiJSyWma kWuIWdbIufmTF3xj36BFpdfd/2gLXS7ZOIrCwjA5afAfH0tYOzDMkepqJYlmHHs1f5Wi1aFNak+mc 2QJyQQ7hqyRMhEVEiodt5/EbkTY+04mjxDD+2+x3t4oD/C4YahwIlcEa+n4Y18bEB/RF/qwH11fE3 4T1FvcBQt2ltTQ==; In-Reply-To: <2D516F0C-D7A8-49D2-8009-F911EFC55C78@secure.kjonigsen.net> (message from Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= on Tue, 5 Sep 2023 21:31:25 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269621 Archived-At: > From: Jostein Kjønigsen > Date: Tue, 5 Sep 2023 21:31:25 +0200 > Cc: Eli Zaretskii , > Yuan Fu , > Theodor Thornhill , > Jostein Kjønigsen , > btuin@mailo.com, > 65470@debbugs.gnu.org > > Sorry for the somewhat slow response on this. Life has been busy for me as well :) > > Based on the infamous “copy, paste & adapt” methodology I’ve come up with a patch for typescript-ts-mode and tsx-ts-mode which seems to work for the simple test case provided above. > > However the patch for js-ts-mode has lots of … interesting stuff about jsx I have not included, for no other reason than not understanding what type of use-cases they are meant to support. > > If someone can provide me some examples for the JSX use-cases, I can try to make room for TSX-variants of the same code. > > The patch so far is attached. It’s intentionally -not- optimized to leave room for TSX cases which may arise, so hopefully no need to nitpick this yet. Thanks, Jostein. Any objections to my installing this on the emacs-29 branch, anyone?