From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler Date: Fri, 20 Oct 2023 10:21:32 +0300 Message-ID: <83ttqlsqrn.fsf@gnu.org> References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> <83wmvhsron.fsf@gnu.org> <87lebx4vhw.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22959"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattias.engdegard@gmail.com, monnier@iro.umontreal.ca, 66636@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 20 09:22:50 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qtjqJ-0005dN-HH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Oct 2023 09:22:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtjqC-00019a-MY; Fri, 20 Oct 2023 03:22:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtjq7-00014H-JS for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2023 03:22:35 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtjq7-0003qr-B3 for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2023 03:22:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qtjqY-0004VU-AH for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2023 03:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Oct 2023 07:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66636 X-GNU-PR-Package: emacs Original-Received: via spool by 66636-submit@debbugs.gnu.org id=B66636.169778654517273 (code B ref 66636); Fri, 20 Oct 2023 07:23:02 +0000 Original-Received: (at 66636) by debbugs.gnu.org; 20 Oct 2023 07:22:25 +0000 Original-Received: from localhost ([127.0.0.1]:38541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtjpx-0004UW-4K for submit@debbugs.gnu.org; Fri, 20 Oct 2023 03:22:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtjpm-0004U9-Dl for 66636@debbugs.gnu.org; Fri, 20 Oct 2023 03:22:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtjpE-0003fB-Fb; Fri, 20 Oct 2023 03:21:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=5Dwz1r5+5G44UoF6dq874G3ClR50vYytzPR6y0cLENM=; b=aRzrIjPnJZ0KHVC9btBZ tkHio14ZW7OfdB76CyUZ0eam36gL1NyxKv2IkzHqfPFZfiJ0G3aaR7O9n6dlEvR1Y+5Y73ywINpAy IePOUvrMJctvssxkZdHdEY85D5XtEqY40fdPGpdqyF9gvFBx9Vc1/xgEoBFzls6Yhm5YqH/tmH7m0 87tnzke4HQAXybgMJzWtW0Gyaoy4ki6aUSsvHHdO/TcLA9LIv/T9l/fgkNBA9x0tlwv6sOHOlFXQJ QORUK+Kgz2+O5wIcQB0JtZGKeVYy2aLsuIBe0GmKql2l86ZAVl2cvDMKRo0SXpYML6QkMMnXrohb+ LMjdiGqxekUcdw==; In-Reply-To: <87lebx4vhw.fsf@yahoo.com> (message from Po Lu on Fri, 20 Oct 2023 15:13:15 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272780 Archived-At: > From: Po Lu > Cc: Stefan Monnier , mattias.engdegard@gmail.com, > 66636@debbugs.gnu.org > Date: Fri, 20 Oct 2023 15:13:15 +0800 > > Eli Zaretskii writes: > > >> Cc: 66636@debbugs.gnu.org > >> Date: Fri, 20 Oct 2023 14:09:45 +0800 > >> From: Po Lu via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> Mattias Engdegård writes: > >> > >> > The warning about a missing lexical-binding cookie rather belongs in > >> > the compiler than checkdoc, because it's not about documentation or > >> > style but code generation and ability to detect errors, both which are > >> > hindered by a missing cookie. > >> > > >> > Moving the warning to the compiler also makes it more widely seen. > >> > >> So long as this warning is only displayed within code part of Emacs > >> itself, there are no valid objections to such a change. > >> > >> But you have instead elected to generate warnings whenever such files > >> are byte-compiled. There exist many packages which do not enable > >> lexical binding, whose authors have studiously elected not to: most of > >> Drew Adams' for example. So this is tantamount to punitive action > >> against their users, in the form of an unsightly warning each time such > >> packages are installed. > > > > Cannot such packages disable this warning in file-local variables? > > I don't think so, at least insomuch as byte-compile-warnings doesn't > function as a file-local variable. Then maybe we should allow that for this new warning (and potentially also other warnings).