From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67028: 29.1; WDired should restore the previous `mode-name' when returning to Dired mode Date: Fri, 10 Nov 2023 10:09:35 +0200 Message-ID: <83ttpuxc5c.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21129"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67028@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 10 09:10:38 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1Mb8-0005IR-GZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Nov 2023 09:10:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1May-0005l9-HK; Fri, 10 Nov 2023 03:10:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1Mat-0005hE-Rk for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 03:10:23 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r1Mat-0005u6-Dx for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 03:10:23 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r1MbW-0000oy-GT for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 03:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Nov 2023 08:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67028 X-GNU-PR-Package: emacs Original-Received: via spool by 67028-submit@debbugs.gnu.org id=B67028.16996038313113 (code B ref 67028); Fri, 10 Nov 2023 08:11:02 +0000 Original-Received: (at 67028) by debbugs.gnu.org; 10 Nov 2023 08:10:31 +0000 Original-Received: from localhost ([127.0.0.1]:49491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1Mb0-0000o9-Ve for submit@debbugs.gnu.org; Fri, 10 Nov 2023 03:10:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1Maw-0000nr-9F for 67028@debbugs.gnu.org; Fri, 10 Nov 2023 03:10:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1MaC-0005ZS-MR; Fri, 10 Nov 2023 03:09:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MXR9JvDegTioauxACXBVzCAV2mJ05TGRxwGcNVnIJNs=; b=DTh8y8VCGjvv QmldTgnszOtpkZb7PsYkQYhedexQKjJAHkKusX312Lq1kJBlE3GND3m/xgOw9KdYZSALMHzi+Pwss bRk5vndWaur2KlRK/fOaWHjefEeGsFCbJ/KbiXRvzdAsYfTionbiWz00zBnwjZQD2hQx23maMedu0 +Lsz8gTJQRQxpMETndTSgss7l7zUAA+IYwSjnCZC/mMAyTNED/Pm57o+cRdz22aQnoM+NChtnTjuB diXaNEZo2OA+wq+1d/vUsbNNawNvQAGhpLCYGYJwDka20lGmq3zdeGRUPYxinmSCf21mdBIprA2NQ 3P2USxuol7W86n9IuYMNeg==; In-Reply-To: (message from Drew Adams on Thu, 9 Nov 2023 20:00:25 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274100 Archived-At: > From: Drew Adams > Date: Thu, 9 Nov 2023 20:00:25 +0000 > > Dunno how simple and sure this would be to do, but I think that when you > quit WDired the mode-line should show the same `mode-name' it showed > before you entered WDired. E.g., if the `mode-name' was "Dired by name" > then it should be restored to that. > > Instead, when you quit WDired the `mode-name' is always set to just > "Dired". You lose the info that the sorting is by name or by date. Thanks. Does the patch below give good results? diff --git a/lisp/wdired.el b/lisp/wdired.el index 7b9c75d..079d93d 100644 --- a/lisp/wdired.el +++ b/lisp/wdired.el @@ -453,7 +453,7 @@ wdired-change-to-dired-mode (force-mode-line-update) (setq buffer-read-only t) (setq major-mode 'dired-mode) - (setq mode-name "Dired") + (dired-sort-set-mode-line) (dired-advertise) (dired-hide-details-update-invisibility-spec) (remove-hook 'kill-buffer-hook #'wdired-check-kill-buffer t)