From: Eli Zaretskii <eliz@gnu.org>
To: casouri@gmail.com
Cc: noah.v.peart@gmail.com, 67357@debbugs.gnu.org, dmitry@gutov.dev
Subject: bug#67357: [PATCH] Fix c-ts-mode block indent when first-siblings are comments
Date: Sat, 09 Dec 2023 10:23:29 +0200 [thread overview]
Message-ID: <83ttoryebi.fsf@gnu.org> (raw)
In-Reply-To: <83cyvs7jte.fsf@gnu.org> (message from Eli Zaretskii on Wed, 29 Nov 2023 15:47:25 +0200)
Ping! Ping! Yuan, please chime is, as I'm waiting for your comments
before we install on the release branch.
This and other patches for TS-based modes are currently delaying the
release of Emacs 29.2, so please try to be more responsive, okay?
> Cc: noah.v.peart@gmail.com, 67357@debbugs.gnu.org, dmitry@gutov.dev
> Date: Wed, 29 Nov 2023 15:47:25 +0200
> From: Eli Zaretskii <eliz@gnu.org>
>
> > Date: Fri, 24 Nov 2023 16:46:32 +0200
> > From: Eli Zaretskii <eliz@gnu.org>
> > Cc: dmitry@gutov.dev, casouri@gmail.com, 67357@debbugs.gnu.org
> >
> > > From: Noah Peart <noah.v.peart@gmail.com>
> > > Date: Fri, 24 Nov 2023 06:35:06 -0800
> > > Cc: dmitry@gutov.dev, casouri@gmail.com, 67357@debbugs.gnu.org
> > >
> > > To reproduce the indentation bugs for unbracketed `else_clause`, and
> > > do-while:
> > > 1. open a buffer and insert the following:
> > >
> > > int main() {
> > > if (true)
> > > puts("Hello");
> > > else
> > > puts("No matched rule!"); // 1
> > > do
> > > puts("Hello");
> > > while (indented_as_part_of_block); // 2
> > > }
> > >
> > > 2. call `M-x example-setup` to configure `c-ts-mode`
> > > 3. `M-x indent-region` to indent the whole buffer
> > > You should see that the line with comment `1` has not been
> > > indented, and the line with comment `2` has been indented to the
> > > same level as the previous line.
> > >
> > > To reproduce the indentation bugs when comments are the first
> > > siblings:
> > > 1. open a buffer and insert:
> > >
> > > int main() {
> > > while (true) { /* foo */
> > > if (true) { // 1
> > > puts ("Hello"); // 2
> > > }
> > > }
> > > }
> > >
> > > 2. call `M-x example-setup` to configure `c-ts-mode`
> > > 3. `M-x indent-region` to indent the whole buffer
> > >
> > > You should see that the lines with comments `1` and `2` have
> > > not been indented at all.
> >
> > Thanks, I see the problems now.
> >
> > Let's wait for Yuan to chime in.
>
> Yuan, could you please comment on the proposed solution? TIA.
>
>
>
>
next prev parent reply other threads:[~2023-12-09 8:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 1:50 bug#67357: [PATCH] Fix c-ts-mode block indent when first-siblings are comments Noah Peart
2023-11-23 7:35 ` Eli Zaretskii
2023-11-23 13:17 ` Dmitry Gutov
2023-11-23 14:33 ` Eli Zaretskii
2023-11-23 14:41 ` Dmitry Gutov
2023-11-24 13:47 ` Noah Peart
2023-11-24 14:07 ` Eli Zaretskii
2023-11-24 14:35 ` Noah Peart
2023-11-24 14:45 ` Noah Peart
2023-11-24 14:46 ` Eli Zaretskii
2023-11-29 13:47 ` Eli Zaretskii
2023-12-09 8:23 ` Eli Zaretskii [this message]
2023-12-10 9:09 ` Yuan Fu
2023-12-10 9:39 ` Eli Zaretskii
2023-12-11 1:11 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ttoryebi.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=67357@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dmitry@gutov.dev \
--cc=noah.v.peart@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.