From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: recent commit broke src/dired.c on OSX
Date: Sun, 25 Jul 2010 20:38:00 +0300
Message-ID: <83sk37bgxz.fsf@gnu.org>
References: <86iq4379w0.fsf@red.stonehenge.com>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: lo.gmane.org
X-Trace: dough.gmane.org 1280079493 2257 80.91.229.12 (25 Jul 2010 17:38:13 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Sun, 25 Jul 2010 17:38:13 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: merlyn@stonehenge.com (Randal L. Schwartz)
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 25 19:38:11 2010
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1Od59O-0004US-0t
	for ged-emacs-devel@m.gmane.org; Sun, 25 Jul 2010 19:38:10 +0200
Original-Received: from localhost ([127.0.0.1]:39348 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1Od59N-0007P5-GB
	for ged-emacs-devel@m.gmane.org; Sun, 25 Jul 2010 13:38:09 -0400
Original-Received: from [140.186.70.92] (port=34382 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Od59H-0007Nf-Ub
	for emacs-devel@gnu.org; Sun, 25 Jul 2010 13:38:04 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <eliz@gnu.org>) id 1Od59G-0004ZZ-Rg
	for emacs-devel@gnu.org; Sun, 25 Jul 2010 13:38:03 -0400
Original-Received: from mtaout20.012.net.il ([80.179.55.166]:36056)
	by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from <eliz@gnu.org>)
	id 1Od59G-0004ZH-Jz
	for emacs-devel@gnu.org; Sun, 25 Jul 2010 13:38:02 -0400
Original-Received: from conversion-daemon.a-mtaout20.012.net.il by
	a-mtaout20.012.net.il (HyperSendmail v2007.08) id
	<0L6400B00JMPNY00@a-mtaout20.012.net.il> for
	emacs-devel@gnu.org; Sun, 25 Jul 2010 20:38:00 +0300 (IDT)
Original-Received: from HOME-C4E4A596F7 ([77.127.61.30]) by a-mtaout20.012.net.il
	(HyperSendmail v2007.08) with ESMTPA id
	<0L64000MAJNBCVM0@a-mtaout20.012.net.il>;
	Sun, 25 Jul 2010 20:38:00 +0300 (IDT)
In-reply-to: <86iq4379w0.fsf@red.stonehenge.com>
X-012-Sender: halo1@inter.net.il
X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:127777
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/127777>

> From: merlyn@stonehenge.com (Randal L. Schwartz)
> Date: Sun, 25 Jul 2010 10:23:59 -0700
> 
> 
> This commit
> 
>   Author: Juanma Barranquero <lekktu@gmail.com>
>   Date:   Sun Jul 25 02:20:51 2010 +0200
> 
> broke the build on OSX.  I believe this is the problem:
> 
>     --- a/src/dired.c
>     +++ b/src/dired.c
>     @@ -66,8 +66,8 @@
>      #ifndef MSDOS
>      #define DIRENTRY struct direct
> 
>     -extern DIR *opendir ();
>     -extern struct direct *readdir ();
>     +extern DIR *opendir (char *);
>     +extern struct direct *readdir (DIR *);
> 
>      #endif /* not MSDOS */
>      #endif /* not SYSV_SYSTEM_DIR */
> 
> Needs to be backed out, or made more portable.

Please show the prototypes of these functions on OSX.

Also, do you have <dirent.h> ?