From: Eli Zaretskii <eliz@gnu.org>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101633: Add fd handling with callbacks to select, dbus needs it for async operation.
Date: Sun, 26 Sep 2010 20:28:09 +0200 [thread overview]
Message-ID: <83sk0wqs06.fsf@gnu.org> (raw)
In-Reply-To: <E1Ozur1-0004Ag-MZ@eggs.gnu.org>
> Date: Sun, 26 Sep 2010 13:17:33 -0400
> From: emacs-diffs-request@gnu.org
>
> @@ -7023,12 +7086,10 @@
> void
> add_keyboard_wait_descriptor (int desc)
> {
> -#ifdef subprocesses
> FD_SET (desc, &input_wait_mask);
> FD_SET (desc, &non_process_wait_mask);
> - if (desc > max_keyboard_desc)
> - max_keyboard_desc = desc;
> -#endif
> + if (desc > max_input_desc)
> + max_input_desc = desc;
> }
>
> /* From now on, do not expect DESC to give keyboard input. */
> @@ -7036,20 +7097,16 @@
> void
> delete_keyboard_wait_descriptor (int desc)
> {
> -#ifdef subprocesses
> int fd;
> - int lim = max_keyboard_desc;
> + int lim = max_input_desc;
>
> FD_CLR (desc, &input_wait_mask);
> FD_CLR (desc, &non_process_wait_mask);
>
> - if (desc == max_keyboard_desc)
> + if (desc == max_input_desc)
> for (fd = 0; fd < lim; fd++)
> - if (FD_ISSET (fd, &input_wait_mask)
> - && !FD_ISSET (fd, &non_keyboard_wait_mask)
> - && !FD_ISSET (fd, &gpm_wait_mask))
> - max_keyboard_desc = fd;
> -#endif /* subprocesses */
The changes that remove the "#ifdef subprocesses" conditionals will
probably break the MSDOS build, because input_wait_mask etc. are only
defined "#ifdef subprocesses". The functions
add_keyboard_wait_descriptor and delete_keyboard_wait_descriptor are
supposed to be no-ops for the MSDOS build.
next parent reply other threads:[~2010-09-26 18:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1Ozur1-0004Ag-MZ@eggs.gnu.org>
2010-09-26 18:28 ` Eli Zaretskii [this message]
2010-09-26 19:07 ` [Emacs-diffs] /srv/bzr/emacs/trunk r101633: Add fd handling with callbacks to select, dbus needs it for async operation Jan Djärv
2010-09-26 19:17 ` Eli Zaretskii
2010-09-26 20:23 ` Jan Djärv
2010-09-26 22:00 ` Eli Zaretskii
[not found] <E1Ozuqt-0004W5-KB@internal.in.savannah.gnu.org>
2010-09-26 19:49 ` Juanma Barranquero
2010-09-26 20:50 ` Jan Djärv
2010-09-26 21:05 ` Juanma Barranquero
2010-09-26 21:59 ` Eli Zaretskii
2010-09-27 6:30 ` Jan Djärv
2010-09-27 7:43 ` Eli Zaretskii
2010-09-27 8:23 ` Jan Djärv
2010-09-27 8:40 ` Eli Zaretskii
2010-09-27 9:09 ` Jan Djärv
2010-09-27 10:33 ` Dan Nicolaescu
2010-09-27 11:53 ` Jan Djärv
2010-09-27 20:43 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sk0wqs06.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jan.h.d@swipnet.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.