From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH updated] Support for filesystem watching (inotify) Date: Sat, 04 Jun 2011 22:15:12 +0300 Message-ID: <83sjrpcssf.fsf@gnu.org> References: <201106040034.15598.ruediger@c-plusplus.de> <831uz9esv1.fsf@gnu.org> <201106041913.09203.ruediger@c-plusplus.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: dough.gmane.org 1307214926 26797 80.91.229.12 (4 Jun 2011 19:15:26 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 4 Jun 2011 19:15:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?utf-8?Q?R=C3=BCdiger?= Sonderfeld Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 04 21:15:22 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QSwJd-0002p5-IP for ged-emacs-devel@m.gmane.org; Sat, 04 Jun 2011 21:15:21 +0200 Original-Received: from localhost ([::1]:60057 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSwJc-0004If-GM for ged-emacs-devel@m.gmane.org; Sat, 04 Jun 2011 15:15:20 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:40119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSwJM-0004IV-0Q for emacs-devel@gnu.org; Sat, 04 Jun 2011 15:15:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QSwJK-0005xL-FO for emacs-devel@gnu.org; Sat, 04 Jun 2011 15:15:03 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:36901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSwJK-0005wn-7c for emacs-devel@gnu.org; Sat, 04 Jun 2011 15:15:02 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LMA002005D2Q200@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Sat, 04 Jun 2011 22:15:00 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.229.223.140]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LMA002F75GYL930@a-mtaout22.012.net.il>; Sat, 04 Jun 2011 22:14:59 +0300 (IDT) In-reply-to: <201106041913.09203.ruediger@c-plusplus.de> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:140180 Archived-At: > From: R=C3=BCdiger Sonderfeld > Date: Sat, 4 Jun 2011 19:13:08 +0200 > Cc: emacs-devel@gnu.org >=20 > Thank you for your comments! I updated the patch and I hope I fixed= everything > except the things noted below. Style of braces is still incorrect, at least in this place: > + if(watchdesc =3D=3D -1) { > + report_file_error("Could not watch file", Fcons(args[0], Qnil)= ); > + } The doc string still uses lines that are too long. See also Jan's important comment about how to expose these events to the rest of Emacs.