From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109306: Use an include file in configure.ac's AH_BOTTOM Date: Tue, 31 Jul 2012 20:31:04 +0300 Message-ID: <83sjc7et2f.fsf@gnu.org> References: <83vch3eu29.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1343755876 30032 80.91.229.3 (31 Jul 2012 17:31:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 31 Jul 2012 17:31:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 31 19:31:16 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SwGHr-0001Z5-Gl for ged-emacs-devel@m.gmane.org; Tue, 31 Jul 2012 19:31:15 +0200 Original-Received: from localhost ([::1]:34195 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwGHq-0002h5-SB for ged-emacs-devel@m.gmane.org; Tue, 31 Jul 2012 13:31:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwGHo-0002g2-MK for emacs-devel@gnu.org; Tue, 31 Jul 2012 13:31:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwGHn-0000dw-IJ for emacs-devel@gnu.org; Tue, 31 Jul 2012 13:31:12 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:52716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwGHn-0000dg-AC; Tue, 31 Jul 2012 13:31:11 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M8100K00CIYK300@a-mtaout20.012.net.il>; Tue, 31 Jul 2012 20:31:09 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M8100KG9CNX1Q90@a-mtaout20.012.net.il>; Tue, 31 Jul 2012 20:31:09 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152014 Archived-At: > From: Juanma Barranquero > Date: Tue, 31 Jul 2012 19:15:37 +0200 > Cc: rgm@gnu.org, emacs-devel@gnu.org > > On Tue, Jul 31, 2012 at 7:09 PM, Eli Zaretskii wrote: > > > What are the manifestations of this trouble? I just built the current > > trunk on Windows, and didn't see any problems. And I don't think any > > related changes were committed since you wrote the above. > > I didn't make myself clear. The trouble is trying to sync nt/config.nt > with autogen/config.in, i.e, removing code from nt/config.nt that is > already in src/conf_post.h. So you are saying that replacing the stuff at the end of nt/config.nt with inclusion of conf_post.h causes compilation failures? I wonder why, because conf_post.h looks like an identical copy of that stuff, and comes at the same place. The alloca.h stuff is already #ifdef'ed away on config.nt, so it's not new. Either ifdef it in conf_post.h, or provide alloca.h in nt/inc. As for AMPERSAND_FULL_NAME, its unconditional definition is bogus IMO, and needs to be autoconfiscated, or at the very least ifdef'ed away for WINDOWSNT and MSDOS. Undefining it on ms-w32.h is possible, but not clean, IMO. > I've had no time to delve into it, but it seems like a problem > compiling the lib sources, not src/*.c. If you bump into problems beyond the above, please bring them up.