From: Eli Zaretskii <eliz@gnu.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109306: Use an include file in configure.ac's AH_BOTTOM
Date: Tue, 31 Jul 2012 20:31:04 +0300 [thread overview]
Message-ID: <83sjc7et2f.fsf@gnu.org> (raw)
In-Reply-To: <CAAeL0SSbajstdgXP_juHxdz+5npm-PH43-s45PLYPJ3f8f9TXA@mail.gmail.com>
> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Tue, 31 Jul 2012 19:15:37 +0200
> Cc: rgm@gnu.org, emacs-devel@gnu.org
>
> On Tue, Jul 31, 2012 at 7:09 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
> > What are the manifestations of this trouble? I just built the current
> > trunk on Windows, and didn't see any problems. And I don't think any
> > related changes were committed since you wrote the above.
>
> I didn't make myself clear. The trouble is trying to sync nt/config.nt
> with autogen/config.in, i.e, removing code from nt/config.nt that is
> already in src/conf_post.h.
So you are saying that replacing the stuff at the end of nt/config.nt
with inclusion of conf_post.h causes compilation failures? I wonder
why, because conf_post.h looks like an identical copy of that stuff,
and comes at the same place.
The alloca.h stuff is already #ifdef'ed away on config.nt, so it's not
new. Either ifdef it in conf_post.h, or provide alloca.h in nt/inc.
As for AMPERSAND_FULL_NAME, its unconditional definition is bogus IMO,
and needs to be autoconfiscated, or at the very least ifdef'ed away
for WINDOWSNT and MSDOS. Undefining it on ms-w32.h is possible, but
not clean, IMO.
> I've had no time to delve into it, but it seems like a problem
> compiling the lib sources, not src/*.c.
If you bump into problems beyond the above, please bring them up.
next prev parent reply other threads:[~2012-07-31 17:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1SvyHP-00051u-7i@vcs.savannah.gnu.org>
2012-07-31 12:10 ` [Emacs-diffs] /srv/bzr/emacs/trunk r109306: Use an include file in configure.ac's AH_BOTTOM Juanma Barranquero
2012-07-31 12:23 ` Juanma Barranquero
2012-07-31 17:09 ` Eli Zaretskii
2012-07-31 17:15 ` Juanma Barranquero
2012-07-31 17:31 ` Eli Zaretskii [this message]
2012-07-31 17:45 ` Eli Zaretskii
2012-07-31 18:01 ` Glenn Morris
2012-07-31 19:17 ` Eli Zaretskii
2012-07-31 19:28 ` Glenn Morris
2012-07-31 19:35 ` Glenn Morris
2012-07-31 19:40 ` Juanma Barranquero
2012-07-31 20:04 ` Eli Zaretskii
2012-07-31 20:22 ` Glenn Morris
2012-07-31 20:33 ` Paul Eggert
2012-07-31 20:03 ` Eli Zaretskii
2012-07-31 19:37 ` Juanma Barranquero
2012-07-31 19:58 ` Juanma Barranquero
2012-07-31 20:06 ` Eli Zaretskii
2012-07-31 20:18 ` Juanma Barranquero
2012-07-31 20:27 ` Glenn Morris
2012-07-31 20:36 ` Glenn Morris
2012-07-31 20:43 ` Paul Eggert
2012-07-31 21:37 ` Juanma Barranquero
2012-07-31 22:50 ` Glenn Morris
2012-07-31 22:57 ` Juanma Barranquero
2012-07-31 23:04 ` Glenn Morris
2012-07-31 23:04 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sjc7et2f.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.