From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12327: Signal-handler cleanup for Emacs Date: Fri, 07 Sep 2012 13:21:34 +0300 Message-ID: <83sjaub0b5.fsf@gnu.org> References: <50494F7F.9080901@cs.ucla.edu> <834nnacqw3.fsf@gnu.org> <83392ucmzq.fsf@gnu.org> <83zk52b5lx.fsf@gnu.org> <5049B768.4010001@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1347013310 28977 80.91.229.3 (7 Sep 2012 10:21:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 7 Sep 2012 10:21:50 +0000 (UTC) Cc: lekktu@gmail.com, 12327@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 07 12:21:51 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T9vh8-0004Y3-TJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Sep 2012 12:21:51 +0200 Original-Received: from localhost ([::1]:54787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9vh5-0002yB-PN for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Sep 2012 06:21:47 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9vh3-0002y6-QI for bug-gnu-emacs@gnu.org; Fri, 07 Sep 2012 06:21:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9vh2-0001o3-Rx for bug-gnu-emacs@gnu.org; Fri, 07 Sep 2012 06:21:45 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9vh2-0001nz-OY for bug-gnu-emacs@gnu.org; Fri, 07 Sep 2012 06:21:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T9vhJ-0004Up-Kx for bug-gnu-emacs@gnu.org; Fri, 07 Sep 2012 06:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Sep 2012 10:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12327 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12327-submit@debbugs.gnu.org id=B12327.134701331817274 (code B ref 12327); Fri, 07 Sep 2012 10:22:01 +0000 Original-Received: (at 12327) by debbugs.gnu.org; 7 Sep 2012 10:21:58 +0000 Original-Received: from localhost ([127.0.0.1]:45510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9vhG-0004UZ-Br for submit@debbugs.gnu.org; Fri, 07 Sep 2012 06:21:58 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:54687) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9vhD-0004UP-CD for 12327@debbugs.gnu.org; Fri, 07 Sep 2012 06:21:56 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M9Z00L005XXDH00@a-mtaout22.012.net.il> for 12327@debbugs.gnu.org; Fri, 07 Sep 2012 13:21:37 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M9Z00LWI6407K50@a-mtaout22.012.net.il>; Fri, 07 Sep 2012 13:21:37 +0300 (IDT) In-reply-to: <5049B768.4010001@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63893 Archived-At: > Date: Fri, 07 Sep 2012 01:59:20 -0700 > From: Paul Eggert > CC: lekktu@gmail.com, 12327@debbugs.gnu.org > > > (Why are there still calls to 'signal', as opposed to 'sigaction', in > > some parts of Emacs?) > > Thanks for catching that. Three of them were wrong -- a glitch when > merging patches. Fixed in trunk bzr 109922. > > The other calls are setting signal handlers to SIG_DFL or SIG_IGN. > For these, signal and sigaction do the same thing, so I left the > calls alone, to minimize changes. If it's better, for regularity > purposes, to replace these 'signal' calls with 'sigaction' calls, > that's an easy and simple change that I can do. I think it's better to use a single family of functions, it makes the code slightly easier to comprehend. But I'm okay with leaving those calls to 'signal', if no one else cares. It just means that 'sys_signal' in the Windows sources will have to be rewritten to call 'sigaction' internally (I left it alone in revision 109919 because I thought it was on its way out).