all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: lekktu@gmail.com, 12327@debbugs.gnu.org
Subject: bug#12327: Signal-handler cleanup for Emacs
Date: Fri, 07 Sep 2012 13:21:34 +0300	[thread overview]
Message-ID: <83sjaub0b5.fsf@gnu.org> (raw)
In-Reply-To: <5049B768.4010001@cs.ucla.edu>

> Date: Fri, 07 Sep 2012 01:59:20 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: lekktu@gmail.com, 12327@debbugs.gnu.org
> 
> > (Why are there still calls to 'signal', as opposed to 'sigaction', in
> > some parts of Emacs?)
> 
> Thanks for catching that.  Three of them were wrong -- a glitch when
> merging patches.  Fixed in trunk bzr 109922.
> 
> The other calls are setting signal handlers to SIG_DFL or SIG_IGN.
> For these, signal and sigaction do the same thing, so I left the
> calls alone, to minimize changes.  If it's better, for regularity
> purposes, to replace these 'signal' calls with 'sigaction' calls,
> that's an easy and simple change that I can do.

I think it's better to use a single family of functions, it makes the
code slightly easier to comprehend.

But I'm okay with leaving those calls to 'signal', if no one else
cares.  It just means that 'sys_signal' in the Windows sources will
have to be rewritten to call 'sigaction' internally (I left it alone
in revision 109919 because I thought it was on its way out).





      reply	other threads:[~2012-09-07 10:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-01 22:38 bug#12327: Signal-handler cleanup for Emacs Paul Eggert
2012-09-02 17:51 ` Eli Zaretskii
2012-09-02 18:37   ` Eli Zaretskii
2012-09-02 19:01   ` Paul Eggert
2012-09-02 21:20     ` Eli Zaretskii
2012-09-03  8:16       ` Paul Eggert
2012-09-03  8:49         ` Andreas Schwab
2012-09-03  9:02           ` Paul Eggert
2012-09-03  9:17             ` Andreas Schwab
2012-09-04  8:12               ` Paul Eggert
2012-09-06 11:59                 ` Andy Moreton
2012-09-06 14:41                   ` martin rudalics
2012-09-06 16:46                     ` Eli Zaretskii
2012-09-06 16:54                       ` Andy Moreton
2012-09-06 17:20                         ` Eli Zaretskii
2012-09-06 17:37                       ` martin rudalics
2012-09-03 15:32         ` Eli Zaretskii
2012-09-07  1:35 ` Paul Eggert
2012-09-07  6:02   ` Eli Zaretskii
2012-09-07  7:26     ` Eli Zaretskii
2012-09-07  8:27       ` Eli Zaretskii
2012-09-07  8:59         ` Paul Eggert
2012-09-07 10:21           ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sjaub0b5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=12327@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.