Re: Hit eassert introduced in r110971

[Eli Zaretskii <eliz@gnu.org>]

> Date: Sat, 06 Apr 2013 21:37:44 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org
> 
> > Date: Sat, 06 Apr 2013 20:35:10 +0400
> > From: Dmitry Antipov <dmantipov@yandex.ru>
> > Cc: Stefan Monnier <monnier@IRO.UMontreal.CA>
> > 
> > Found 100% method to hit eassert introduced in r110971 within update_tool_bar:
> > 
> > 1) ./src/emacs -nw -Q
> > 2) M-x make-frame-on-display :0
> > 3) Move mouse to new X frame and left-click;
> > 4) Move mouse back to TTY frame and left-click;
> > 5) Press C-g staying in TTY frame ==>
> > 
> > #0  0x0000003daf40eedb in raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/pt-raise.c:41
> > #1  0x00000000005a1cf2 in terminate_due_to_signal (sig=6, backtrace_limit=2147483647)
> >      at src/emacs.c:343
> > #2  0x000000000065d92d in die (msg=0x79db98 "assertion failed: EQ (selected_window, XFRAME (selected_frame)->selected_window)", file=
> >      0x79b560 "src/xdisp.c", line=11427) at src/alloc.c:6522
> > #3  0x000000000044c6b5 in update_tool_bar (f=f@entry=0x14a29d8, save_match_data=save_match_data@entry=0)
> >      at src/xdisp.c:11424
> 
> Which frame is the selected frame here: the X frame or the TTY frame?

And btw, why do we at all care here about the selected window?
AFAICS, none of the code involved ever changes that.

Or, if we do care (maybe some weird code that updates the tool bar can
switch windows?), then simply saving and restoring it would be better
than the assertion.

Stefan, am I missing something?