From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 14403@debbugs.gnu.org
Subject: bug#14403: 24.3.50; [regression] Typing non-ascii characters on a non-GUI MS-Windows session
Date: Wed, 15 May 2013 11:13:03 +0300 [thread overview]
Message-ID: <83sj1o64q8.fsf@gnu.org> (raw)
In-Reply-To: <jwv7gj1mc4n.fsf-monnier+emacs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: dmoncayo@gmail.com, 14403@debbugs.gnu.org
> Date: Tue, 14 May 2013 18:28:35 -0400
>
> > This is an exact duplicate of 14368, discussed just yesterday.
>
> Hmm, this looks different, since it doesn't seem to use quail
Different, yes. But caused by the same change in keyboard.c.
> Is it the case that the non-GUI code in Windows receives decoded
> chars in `read_char', contrary to the posix code which receives
> encoded chars there?
Both GUI and non-GUI keyboard input on Windows produce Unicode
codepoints of the characters the user types. The produced input
events have the 'kind' of either ASCII_KEYSTROKE_EVENT or
MULTIBYTE_CHAR_KEYSTROKE_EVENT. They are returned via this call
sequence:
read_char -> kbd_buffer_get_event -> make_lispy_event
I guess the solution is to tell read_decoded_char more about the event
that produced the character?
Or maybe we should not set the keyboard encoding to the console
codepage on Windows (although I have no idea what kind of breakage
this could cause)? What setting of keyboard-coding-system tells the
condition below that no decoding is needed?
Of course, we could always augment this condition:
if (!((FRAME_TERMCAP_P (frame) || FRAME_MSDOS_P (frame))
&& (TERMINAL_KEYBOARD_CODING (terminal)->common_flags
& CODING_REQUIRE_DECODING_MASK)))
return nextevt; /* No decoding needed. */
to do something special for MS-Windows, but that sounds kludgey.
next prev parent reply other threads:[~2013-05-15 8:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 19:11 bug#14403: 24.3.50; [regression] Typing non-ascii characters on a non-GUI MS-Windows session dmoncayo
2013-05-14 19:48 ` Eli Zaretskii
2013-05-14 22:28 ` Stefan Monnier
2013-05-15 8:13 ` Eli Zaretskii [this message]
2013-05-22 16:06 ` Stefan Monnier
2013-05-22 20:39 ` Eli Zaretskii
2013-05-22 21:22 ` Stefan Monnier
2013-05-23 2:46 ` Eli Zaretskii
2013-05-23 14:02 ` Stefan Monnier
2013-05-23 16:23 ` Eli Zaretskii
2013-05-23 17:22 ` Dani Moncayo
2013-05-23 17:38 ` Juanma Barranquero
2013-05-22 20:22 ` Juanma Barranquero
2013-05-22 20:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sj1o64q8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=14403@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.