From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: sdl.web@gmail.com, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r115434: * subr.el (read-passwd): Disable show-paren-mode.
Date: Tue, 10 Dec 2013 05:52:21 +0200 [thread overview]
Message-ID: <83siu1xszu.fsf@gnu.org> (raw)
In-Reply-To: <jwvsiu1cu06.fsf-monnier+emacsdiffs@gnu.org>
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Date: Mon, 09 Dec 2013 21:36:46 -0500
> Cc: emacs-devel@gnu.org
>
> > * subr.el (read-passwd): Disable show-paren-mode.
>
> Should we disable show-paren-mode's highlighting when the paren is
> covered by a `display' property?
It's not just show-paren-mode. It's any mode that looks at buffer
text disregarding the display properties.
For that reason, I think read-passwd should use a completely different
implementation, because otherwise it will reveal the secrets with the
next random Emacs feature.
As for your question, I believe the answer is YES, we should not
highlight parentheses covered by display properties.
next prev parent reply other threads:[~2013-12-10 3:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1Vpqlh-0007jZ-DD@vcs.savannah.gnu.org>
2013-12-10 2:36 ` [Emacs-diffs] trunk r115434: * subr.el (read-passwd): Disable show-paren-mode Stefan Monnier
2013-12-10 3:52 ` Eli Zaretskii [this message]
2013-12-10 7:52 ` martin rudalics
2013-12-11 4:29 ` Stefan Monnier
2013-12-11 8:14 ` martin rudalics
2013-12-11 15:13 ` Stefan Monnier
2013-12-11 17:55 ` martin rudalics
[not found] ` <<83siu1xszu.fsf@gnu.org>
2013-12-10 3:59 ` Drew Adams
2013-12-10 4:12 ` Leo Liu
2013-12-10 16:35 ` Eli Zaretskii
2013-12-10 17:51 ` Josh
2013-12-10 18:17 ` Eli Zaretskii
2013-12-11 0:03 ` Leo Liu
2013-12-11 4:19 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83siu1xszu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.