From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: --enable-gcc-warnings is broken on Fedora 21 by GnuTLS code Date: Sat, 27 Dec 2014 10:08:43 +0200 Message-ID: <83sig1ldkk.fsf@gnu.org> References: <548AA97A.90404@yandex.ru> <83fvcls0ce.fsf@gnu.org> <5499497A.5020601@yandex.ru> <5499DDEA.4070005@cs.ucla.edu> <549A664C.4040908@yandex.ru> <549CA974.5000807@cs.ucla.edu> <83a92an7ji.fsf@gnu.org> <549D9D03.6030404@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1419667755 31053 80.91.229.3 (27 Dec 2014 08:09:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 27 Dec 2014 08:09:15 +0000 (UTC) Cc: larsi@gnus.org, dmantipov@yandex.ru, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 27 09:09:08 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y4mQs-00014R-0O for ged-emacs-devel@m.gmane.org; Sat, 27 Dec 2014 09:09:06 +0100 Original-Received: from localhost ([::1]:55290 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4mQq-00055d-UD for ged-emacs-devel@m.gmane.org; Sat, 27 Dec 2014 03:09:04 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4mQc-0004vX-5d for emacs-devel@gnu.org; Sat, 27 Dec 2014 03:08:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y4mQX-00058q-Q2 for emacs-devel@gnu.org; Sat, 27 Dec 2014 03:08:50 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:55307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y4mQX-00058i-Hz for emacs-devel@gnu.org; Sat, 27 Dec 2014 03:08:45 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NH800700EFOV300@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Sat, 27 Dec 2014 10:08:43 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NH8007QWEMJTJ10@a-mtaout22.012.net.il>; Sat, 27 Dec 2014 10:08:43 +0200 (IST) In-reply-to: <549D9D03.6030404@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:180707 Archived-At: > Date: Fri, 26 Dec 2014 09:38:11 -0800 > From: Paul Eggert > CC: dmantipov@yandex.ru, emacs-devel@gnu.org, larsi@gnus.org > > Eli Zaretskii wrote: > > All of the optional libraries use this > > method, so making GnuTLS an exception is bad for maintenance. > > Then let's change the method everywhere; that avoids the exception. > The idea is to better decouple the generic code from > WINDOWSNT-specific DLL issues. Revised patches attached. Thanks, the first patch is fine with me, with two gotchas: > +# define inflateInit2(strm, windowBits) \ > + inflateInit2_ (strm, windowBits, ZLIB_VERSION, sizeof (z_stream)) This will trigger a redifinition warning from the compiler, since zlib.h already includes such a #define. > +static bool > +load_dll_functions (void) > +{ > + LOAD_DLL_FN (library, htmlReadMemory); > + LOAD_DLL_FN (library, xmlReadMemory); > + LOAD_DLL_FN (library, xmlDocGetRootElement); > + LOAD_DLL_FN (library, xmlFreeDoc); > + LOAD_DLL_FN (library, xmlCleanupParser); > + LOAD_DLL_FN (library, xmlCheckVersion); > + return true; > +} This won't compile, since 'library' is not defined (it needs to be passed as an argument).