From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19865: tar-untar-buffer: should honor default-directory Date: Tue, 17 Feb 2015 05:37:23 +0200 Message-ID: <83sie5tdho.fsf@gnu.org> References: <87a90gd91b.fsf@violet.siamics.net> <83sie8wn8z.fsf@gnu.org> <831tlpvp35.fsf@gnu.org> <83twyltz5x.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1424144301 30051 80.91.229.3 (17 Feb 2015 03:38:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Feb 2015 03:38:21 +0000 (UTC) Cc: ivan@siamics.net, 19865@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 17 04:38:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YNYzB-0005RK-Bh for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Feb 2015 04:38:09 +0100 Original-Received: from localhost ([::1]:43731 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNYzA-0002pP-GP for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Feb 2015 22:38:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNYz7-0002pJ-JB for bug-gnu-emacs@gnu.org; Mon, 16 Feb 2015 22:38:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNYz4-00049N-DG for bug-gnu-emacs@gnu.org; Mon, 16 Feb 2015 22:38:05 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54509) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNYz4-00049A-9x for bug-gnu-emacs@gnu.org; Mon, 16 Feb 2015 22:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YNYz3-0003le-QX for bug-gnu-emacs@gnu.org; Mon, 16 Feb 2015 22:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Feb 2015 03:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19865 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19865-submit@debbugs.gnu.org id=B19865.142414424714439 (code B ref 19865); Tue, 17 Feb 2015 03:38:01 +0000 Original-Received: (at 19865) by debbugs.gnu.org; 17 Feb 2015 03:37:27 +0000 Original-Received: from localhost ([127.0.0.1]:45749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNYyT-0003ko-KI for submit@debbugs.gnu.org; Mon, 16 Feb 2015 22:37:26 -0500 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:46045) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNYyQ-0003kW-7U for 19865@debbugs.gnu.org; Mon, 16 Feb 2015 22:37:23 -0500 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NJW00700CE9W100@mtaout29.012.net.il> for 19865@debbugs.gnu.org; Tue, 17 Feb 2015 05:33:15 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJW005DMCJEH120@mtaout29.012.net.il>; Tue, 17 Feb 2015 05:33:15 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99485 Archived-At: > From: Stefan Monnier > Cc: ivan@siamics.net, 19865@debbugs.gnu.org > Date: Mon, 16 Feb 2015 18:40:51 -0500 > > > if you changed a directory, you need to go back before you operate on > > files, or risk operate on wrong files. > > No: I changed directory specifically because I wanted to operate on > other files. And I often don't go back. Then your next delete command will probably delete wrong files. > > I don't really see a problem here that needs a solution. A year from > > now no one will remember or understand why we use with-current-buffer > > in that place. > > The comment explains why and the comment will still be there a year > from now. Comments cannot be a replacement for clear, self-explanatory code that has no hidden dependencies. > The code takes a file name from one buffer and uses it in another > buffer: every time we do it, we have to be extra careful to make sure > the file name is absolute, and that's what the patch does. If both buffers has the same default-directory, as they should, there's no need to do anything special.