From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Date: Sat, 28 Feb 2015 09:59:45 +0200 Message-ID: <83sidq4gb2.fsf@gnu.org> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> <54F0EEF2.1030908@cornell.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1425110428 21934 80.91.229.3 (28 Feb 2015 08:00:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 28 Feb 2015 08:00:28 +0000 (UTC) Cc: 19909@debbugs.gnu.org, rpluim@gmail.com To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 28 09:00:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YRcJp-0000QM-5G for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Feb 2015 09:00:13 +0100 Original-Received: from localhost ([::1]:40294 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRcJo-0000DW-CU for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Feb 2015 03:00:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRcJk-0000AP-Pb for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 03:00:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRcJf-0005ql-RW for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 03:00:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRcJf-0005q0-Oj for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 03:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YRcJf-0005GX-CQ for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 03:00:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Feb 2015 08:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, rpluim@gmail.com Original-Received: via spool by submit@debbugs.gnu.org id=B.142511038220187 (code B ref -1); Sat, 28 Feb 2015 08:00:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Feb 2015 07:59:42 +0000 Original-Received: from localhost ([127.0.0.1]:60340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRcJJ-0005FX-G2 for submit@debbugs.gnu.org; Sat, 28 Feb 2015 02:59:41 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58793) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRcJH-0005FF-K5 for submit@debbugs.gnu.org; Sat, 28 Feb 2015 02:59:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRcJB-0005hj-GR for submit@debbugs.gnu.org; Sat, 28 Feb 2015 02:59:34 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:54678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRcJB-0005hc-Cr for submit@debbugs.gnu.org; Sat, 28 Feb 2015 02:59:33 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRcJA-00006T-50 for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 02:59:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRcJ5-0005fh-7P for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 02:59:32 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:38212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRcJ4-0005fM-V1 for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 02:59:27 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NKH00E001XTIY00@a-mtaout20.012.net.il> for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 09:59:25 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKH00ESE270I020@a-mtaout20.012.net.il>; Sat, 28 Feb 2015 09:59:25 +0200 (IST) In-reply-to: <54F0EEF2.1030908@cornell.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99893 Archived-At: > Date: Fri, 27 Feb 2015 17:25:54 -0500 > From: Ken Brown > CC: bug-gnu-emacs@gnu.org, rpluim@gmail.com > > It looks like it might not take much effort. What I did for now, just > for testing purposes, is to copy into w32notify.c whatever was necessary > to make the Cygwin-w32 build compile with w32 file notification. I > tested it briefly and it seems to work. Obviously it needs much more > testing to make sure this doesn't break anything else, and then we can > worry about how to do this right. Thanks. A few comments: . Cygwin doesn't need to call MultiByteToWideChar and WideCharToMultiByte via function pointers, it can call them directly. . I think there shouldn't be a need to call filename_to_utf16 and its ilk, but instead use the to_unicode etc., like the rest of Cygwin-w32 code does. E.g., just use GUI_ENCODE_FILE defined on w32term.h.