From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21934: 24.5; find-tag: reading TAGS file incorrectly Date: Sun, 22 Nov 2015 18:12:55 +0200 Message-ID: <83si3y2et4.fsf@gnu.org> References: <87ziyd20cb.fsf@winky.hogwarts> <564AA697.9000203@yandex.ru> <83egfj4i2b.fsf@gnu.org> <56511795.2050207@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1448208860 11992 80.91.229.3 (22 Nov 2015 16:14:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Nov 2015 16:14:20 +0000 (UTC) Cc: andreas.matthias@gmail.com, 21934@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 22 17:14:09 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a0XHE-0008WO-8C for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Nov 2015 17:14:08 +0100 Original-Received: from localhost ([::1]:56562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0XHE-0004Dp-GS for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Nov 2015 11:14:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0XHB-0004Cx-R7 for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 11:14:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0XH8-0006ud-Is for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 11:14:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0XH8-0006uZ-FG for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 11:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a0XH8-0003IB-2w for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2015 11:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Nov 2015 16:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21934 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21934-submit@debbugs.gnu.org id=B21934.144820878612571 (code B ref 21934); Sun, 22 Nov 2015 16:14:02 +0000 Original-Received: (at 21934) by debbugs.gnu.org; 22 Nov 2015 16:13:06 +0000 Original-Received: from localhost ([127.0.0.1]:48357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0XGD-0003Gh-Qq for submit@debbugs.gnu.org; Sun, 22 Nov 2015 11:13:06 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:49742) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a0XGC-0003GY-0n for 21934@debbugs.gnu.org; Sun, 22 Nov 2015 11:13:04 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NY800K00500UR00@a-mtaout23.012.net.il> for 21934@debbugs.gnu.org; Sun, 22 Nov 2015 18:13:02 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NY800KPP51QSP20@a-mtaout23.012.net.il>; Sun, 22 Nov 2015 18:13:02 +0200 (IST) In-reply-to: <56511795.2050207@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109068 Archived-At: > Cc: 21934@debbugs.gnu.org, andreas.matthias@gmail.com > From: Dmitry Gutov > Date: Sun, 22 Nov 2015 03:17:09 +0200 > > > The OP complained about _completion_ on tag names, and suggested to > > fix a regexp used by etags-tags-completion-table. That regexp indeed > > doesn't allow a period in an identifier name (probably because it's > > disallowed in C-like languages). However, find-tag itself doesn't use > > that regexp, > > If does, for completion. Type M-x find-tag RET TAB, and you'll see the > result of calling etags-tags-completion-table. Completion is not an integral part of find-tag. > > Now, find-tag is deprecated in Emacs 25, and M-. invokes > > xref-find-definitions instead. AFAIU, etags-tags-completion-table is > > no longer relevant with xref. > > It's (almost) just as relevant: type C-u M-. TAB. As I said, completion in M-. in Emacs 25 works worse than in find-tag in this case: it doesn't even succeed to complete "Rec TAB" into "Rectangle". I don't know why. > > xref-find-definitions, if it's invoked > > with a prefix argument, and if you type "Rectangle.getPos RET" at its > > prompt, not surprisingly also finds the identifier. Trying to invoke > > completion after "C-u M-.", with test.lua as the current buffer, > > doesn't succeed to complete even on Rectangle, so the situation here > > is somewhat worse, but I'm not sure why. > > Is it really any different? M-x find-tag RET TAB doesn't show anything > beginning with "Rectangle" either. I only get "getPos" as a completion > either way. It's different if you type "Rec TAB". > Either etags will have to consider that in both example declarations the > tag name must be "getPos", not "xxx.getPos", and put this tag name > explicitly into the entries, or lua-mode will have to change the syntax > class of "." to "symbol", so that (thing-at-point 'symbol) returns > "Circle.getPos" as the tag name. Something like that, yes. My main point is that it's easy to solve the completion case, but that hardly help in using TAGS with Lua and the new xref commands. Something else is missing.