From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: More over-engineering Date: Fri, 27 Nov 2015 20:19:17 +0200 Message-ID: <83si3rqp96.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1448648387 25559 80.91.229.3 (27 Nov 2015 18:19:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 Nov 2015 18:19:47 +0000 (UTC) Cc: aurelien.aptel+emacs@gmail.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 27 19:19:36 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a2NcN-00063M-Lw for ged-emacs-devel@m.gmane.org; Fri, 27 Nov 2015 19:19:35 +0100 Original-Received: from localhost ([::1]:58092 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2NcQ-0006QO-Ek for ged-emacs-devel@m.gmane.org; Fri, 27 Nov 2015 13:19:38 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2NcN-0006QG-UT for emacs-devel@gnu.org; Fri, 27 Nov 2015 13:19:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2NcJ-0008RL-0Q for emacs-devel@gnu.org; Fri, 27 Nov 2015 13:19:35 -0500 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:40440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2NcI-0008PQ-P0 for emacs-devel@gnu.org; Fri, 27 Nov 2015 13:19:30 -0500 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NYH00J00JOCKZ00@mtaout28.012.net.il> for emacs-devel@gnu.org; Fri, 27 Nov 2015 20:18:27 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NYH00J68K6Q1E20@mtaout28.012.net.il>; Fri, 27 Nov 2015 20:18:27 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.184 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195406 Archived-At: > From: Stefan Monnier > Date: Fri, 27 Nov 2015 13:02:56 -0500 > Cc: Emacs development discussions > > should protect itself from signals and 'throw' in the called > Emacs functions, by placing the macros MODULE_HANDLE_SIGNALS > and/or MODULE_HANDLE_THROW right after the above 2 tests. > + FIXME: Why is it always needed? What happens if we don't? > + Why is only one of the two needed rather than always both? I indeed think we should have only one macro that does the job of all three of them. It's on my todo to make that change, if no one beats me to it.