From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Override Windows default Win-* key combinations when using Emacs Date: Wed, 13 Jan 2016 17:49:56 +0200 Message-ID: <83si21iimz.fsf@gnu.org> References: <568BBC58.50702@aprikoodi.fi> <83y4c43qkh.fsf@gnu.org> <5691667C.5000009@aprikoodi.fi> <838u3wkkvb.fsf@gnu.org> <5694E07E.8010005@aprikoodi.fi> <83fuy2kd2w.fsf@gnu.org> <5695E146.4060201@aprikoodi.fi> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1452700902 22302 80.91.229.3 (13 Jan 2016 16:01:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Jan 2016 16:01:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jussi Lahdenniemi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 13 17:01:36 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aJNrc-0002Ji-AP for ged-emacs-devel@m.gmane.org; Wed, 13 Jan 2016 17:01:36 +0100 Original-Received: from localhost ([::1]:37882 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJNrb-0006Q0-Q0 for ged-emacs-devel@m.gmane.org; Wed, 13 Jan 2016 11:01:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJNgH-0007kv-RI for emacs-devel@gnu.org; Wed, 13 Jan 2016 10:49:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJNgD-0003Gy-Rx for emacs-devel@gnu.org; Wed, 13 Jan 2016 10:49:53 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59936) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJNgD-0003Gr-P7; Wed, 13 Jan 2016 10:49:49 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1581 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aJNg7-0000TB-L0; Wed, 13 Jan 2016 10:49:44 -0500 In-reply-to: <5695E146.4060201@aprikoodi.fi> (message from Jussi Lahdenniemi on Wed, 13 Jan 2016 07:31:50 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198112 Archived-At: > Cc: emacs-devel@gnu.org > From: Jussi Lahdenniemi > Date: Wed, 13 Jan 2016 07:31:50 +0200 > > On 12.1.2016 17.54, Eli Zaretskii wrote: > > Which APIs that you used in the patch are not available on Windows 9X? > > I thought I went over all of them, and they all are, but maybe I > > missed some. > > Actually, there is only one: GetConsoleWindow. However, the > WH_KEYBOARD_LL hook is not implemented at all on Win98. Right. I checked the APIs, but not the values of the parameters. > So, if we want to offer the old > w32-register-hot-key/w32-phantom-key-code functionality to users of > Win98, the new patch needs to be added to the existing code instead > of replacing it. > > Which road should I take? Assuming that the patch runs on Win2k, the > only people affected by the choice are those running Win98 and ME. Keep > the old functionality for a bit messier code base and documentation, or > replace the old functionality and have Win98/ME people lose > w32-register-hot-key? The former, I guess. We still want to support Windows 9X. Thanks.