From: Eli Zaretskii <eliz@gnu.org>
To: "Andreas Röhler" <andreas.roehler@easy-emacs.de>
Cc: 22847@debbugs.gnu.org
Subject: bug#22847: #17062: 24.3 current-fill-column breaks fill-match-adaptive-prefix
Date: Mon, 29 Feb 2016 17:56:54 +0200 [thread overview]
Message-ID: <83si0b8q7t.fsf@gnu.org> (raw)
In-Reply-To: <56D3F443.9000706@easy-emacs.de> (message from Andreas Röhler on Mon, 29 Feb 2016 08:33:23 +0100)
> From: Andreas Röhler <andreas.roehler@easy-emacs.de>
> Date: Mon, 29 Feb 2016 08:33:23 +0100
>
> fill-match-adaptive-prefix counts on current-fill-column having:
>
> (>= (+ (current-left-margin) (length str)) (current-fill-column))
>
> This will be broken if current-fill-column returns nil.
>
> Returning nil is possible, see inside current-fill-column:
>
> (if fill-column
>
> If fill-column is nil, current-fill-column will return nil which was the case coming upon.
> A fix might make sure an integer is returned anyway: think at 0 or default value.
While at that, please also fix the calculation of string length: it
should use 'string-width', not 'length', IMO.
next prev parent reply other threads:[~2016-02-29 15:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 7:33 bug#22847: #17062: 24.3 current-fill-column breaks fill-match-adaptive-prefix Andreas Röhler
2016-02-29 15:56 ` Eli Zaretskii [this message]
2016-12-08 22:32 ` Glenn Morris
2016-12-09 8:08 ` Eli Zaretskii
2016-12-11 2:18 ` Glenn Morris
2020-08-15 5:14 ` Stefan Kangas
2021-05-10 11:48 ` Lars Ingebrigtsen
2021-05-10 13:29 ` Stefan Kangas
2021-05-12 13:25 ` Lars Ingebrigtsen
2021-07-23 12:58 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83si0b8q7t.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=22847@debbugs.gnu.org \
--cc=andreas.roehler@easy-emacs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.