From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] src/print.c: Check for __GLIBC__ rather than GNU_LINUX Date: Fri, 01 Apr 2016 09:43:19 +0300 Message-ID: <83shz5u8vs.fsf@gnu.org> References: <1459315328-3663-1-git-send-email-somasissounds@gmail.com> <56FD8A8B.3040808@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1459493052 24146 80.91.229.3 (1 Apr 2016 06:44:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Apr 2016 06:44:12 +0000 (UTC) Cc: emacs-devel@gnu.org, somasis@exherbo.org, somasissounds@gmail.com To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 01 08:44:07 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1alsoP-000473-NV for ged-emacs-devel@m.gmane.org; Fri, 01 Apr 2016 08:44:05 +0200 Original-Received: from localhost ([::1]:36255 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alsoP-00038H-6K for ged-emacs-devel@m.gmane.org; Fri, 01 Apr 2016 02:44:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1also5-0002wE-DE for emacs-devel@gnu.org; Fri, 01 Apr 2016 02:43:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1also1-0000bY-DG for emacs-devel@gnu.org; Fri, 01 Apr 2016 02:43:45 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alsnq-0000Vt-Ea; Fri, 01 Apr 2016 02:43:30 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2602 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1alsnp-0005gj-3C; Fri, 01 Apr 2016 02:43:29 -0400 In-reply-to: <56FD8A8B.3040808@cs.ucla.edu> (message from Paul Eggert on Thu, 31 Mar 2016 13:37:31 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202551 Archived-At: > From: Paul Eggert > Date: Thu, 31 Mar 2016 13:37:31 -0700 > Cc: Kylie McClain > > I haven't installed it into 'master' yet, to give Eli a heads-up about > the impending change. Thanks. I needed the additional patch below to get the patch to compile (how do other ports get F_DUPFD_CLOEXEC?). After that, temacs seems to hang during loadup. Looks like it hangs inside the libc function 'close'. I don't have enough free time now to do anything serious on master. Hopefully, someone else will be able to look into this, find out why it hangs, and suggest a remedy. --- src/print.c~0 2016-04-01 09:32:53.060500000 +0300 +++ src/print.c 2016-04-01 09:36:24.591750000 +0300 @@ -38,6 +38,10 @@ along with GNU Emacs. If not, see #include +#ifdef WINDOWSNT +#include /* for F_DUPFD_CLOEXEC */ +#endif + struct terminal; /* Avoid actual stack overflow in print. */