From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23179: 25.0.92; Restore `M-,' to continue etags search Date: Sat, 02 Apr 2016 22:58:26 +0300 Message-ID: <83shz3rdel.fsf@gnu.org> References: <83io01u1gn.fsf@gnu.org> <83d1q9tx0m.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1459627222 487 80.91.229.3 (2 Apr 2016 20:00:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Apr 2016 20:00:22 +0000 (UTC) Cc: 23179@debbugs.gnu.org, dgutov@yandex.ru To: Anders Lindgren Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 02 22:00:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1amRiM-00037Y-KO for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Apr 2016 22:00:10 +0200 Original-Received: from localhost ([::1]:50806 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amRiM-0008KC-0t for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Apr 2016 16:00:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amRiI-0008Jb-Hi for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 16:00:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amRiF-0005Qs-Bx for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 16:00:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amRiF-0005Qe-8x for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 16:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1amRiF-0001Ud-0k for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 16:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Apr 2016 20:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23179-submit@debbugs.gnu.org id=B23179.14596271475642 (code B ref 23179); Sat, 02 Apr 2016 20:00:02 +0000 Original-Received: (at 23179) by debbugs.gnu.org; 2 Apr 2016 19:59:07 +0000 Original-Received: from localhost ([127.0.0.1]:49153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amRhK-0001Sw-TI for submit@debbugs.gnu.org; Sat, 02 Apr 2016 15:59:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35791) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amRhJ-0001SQ-Im for 23179@debbugs.gnu.org; Sat, 02 Apr 2016 15:59:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amRhB-0005Dg-8i for 23179@debbugs.gnu.org; Sat, 02 Apr 2016 15:59:00 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amRhB-0005Dc-5H; Sat, 02 Apr 2016 15:58:57 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1656 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1amRhA-00074k-E3; Sat, 02 Apr 2016 15:58:56 -0400 In-reply-to: (message from Anders Lindgren on Sat, 2 Apr 2016 21:46:48 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115891 Archived-At: > Date: Sat, 2 Apr 2016 21:46:48 +0200 > From: Anders Lindgren > Cc: 23179@debbugs.gnu.org > > The "xref" package is a big step forward, since it supports multiple backends etc. Unfortunately, vital > functionality is missing -- searching and query-replace in all included files. Personally, I use `tags-search' at > least 20 times per day (often more), and `tags-query-replace' several times each week. I don't think that my > use pattern is extreme by any means. Did you try any of the alternatives suggested in this discussion? If none of them satisfies your needs, can you elaborate why? > I think that we would be making a big mistake if we would release Emacs 25 with an "xref" without searching > and query-replace, but with key bindings that, for most tags users, break existing use patterns. We are still discussing this issue, don't we? ;-) And Emacs 25.1 release is still a couple of months away, so we still have time. > > But we could have a tags-only command that presented an xref UI, I think. (Its name could be "tags-search" > ;-) > > > It would have been neat... Unfortunately, the problem is not launching the command, but rather continue > searching past the first match -- since a source buffer, and not the xref UI buffer, will be current. The xref UI solve this problem, as was already mentioned in this discussion. > I have given this some thought -- if we decide to really do make a change, maybe we should try to make the > xref search command more isearch-like, so that a user could be able to continue an xref search using `C-s' > rather than `M-,'. Unfortunately, there is no natural key binding to continue a normal query replace, but we > could create something like `xref-query-replace-from-here', to continue query-replacing from the point in the > current buffer and then continue with the next file in the file list. xref-query-replace-in-results already provides a way for continuing the replacement, so I'm not sure what you are had in mind here.