From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#6430: Emacs WINDOWS truncates exit status of processes to 8 bits Date: Wed, 15 Jun 2016 20:32:43 +0300 Message-ID: <83shwecq84.fsf@gnu.org> References: <1310.80.58.205.52.1276622459.squirrel@correo.ozu.es> <831t3zg7or.fsf@gnu.org> <83d1njdvk9.fsf@gnu.org> <87mvmmk52b.fsf@wanadoo.es> <8337oeebr0.fsf@gnu.org> <87inxajxed.fsf@wanadoo.es> <83y466cvfs.fsf@gnu.org> <87eg7yjrwu.fsf@wanadoo.es> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1466012045 29844 80.91.229.3 (15 Jun 2016 17:34:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Jun 2016 17:34:05 +0000 (UTC) Cc: macross84@ozu.es, 6430@debbugs.gnu.org, npostavs@users.sourceforge.net To: =?UTF-8?Q?=C3=93scar?= Fuentes Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 15 19:33:54 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bDEhO-0002yx-1K for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Jun 2016 19:33:54 +0200 Original-Received: from localhost ([::1]:44019 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDEhN-0003Lv-BJ for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Jun 2016 13:33:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDEfg-0002ET-CZ for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2016 13:32:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDEfa-0000Kf-BX for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2016 13:32:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDEfa-0000Ka-81 for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2016 13:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bDEfa-00038H-1G for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2016 13:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jun 2016 17:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6430 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 6430-submit@debbugs.gnu.org id=B6430.146601192012034 (code B ref 6430); Wed, 15 Jun 2016 17:32:01 +0000 Original-Received: (at 6430) by debbugs.gnu.org; 15 Jun 2016 17:32:00 +0000 Original-Received: from localhost ([127.0.0.1]:42556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDEfY-000382-96 for submit@debbugs.gnu.org; Wed, 15 Jun 2016 13:32:00 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDEfW-00037m-UX for 6430@debbugs.gnu.org; Wed, 15 Jun 2016 13:31:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDEfO-0000ID-LN for 6430@debbugs.gnu.org; Wed, 15 Jun 2016 13:31:53 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDEfO-0000I2-IS; Wed, 15 Jun 2016 13:31:50 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2111 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bDEfM-000409-FV; Wed, 15 Jun 2016 13:31:49 -0400 In-reply-to: <87eg7yjrwu.fsf@wanadoo.es> (message from =?UTF-8?Q?=C3=93scar?= Fuentes on Wed, 15 Jun 2016 19:14:25 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119591 Archived-At: > From: Óscar Fuentes > Cc: npostavs@users.sourceforge.net, macross84@ozu.es, 6430@debbugs.gnu.org > Date: Wed, 15 Jun 2016 19:14:25 +0200 > > Eli Zaretskii writes: > > >> > GetLastError has nothing to do with this, because it's not an API that > >> > fails, it's a program that exits with some arbitrary exit code. > >> > >> if( ! CreateProcess(....) ) { > >> DWORD ec = GetLastError(); > >> // do some cleanup > >> ExitProcess(ec); > >> } > > > > That's not how Emacs does that, see waitpid and its callers. > > Once again, we are miscommunicating. AFAIU this is about Emacs calling a > process foo which returns an exit code larger than 255, but Emacs only > reports the lower 8 bits to the Elisp function that started the process. > > In w32proc.c waitpid: > > if (!GetExitCodeProcess (wait_hnd[active], &retval)) > ... > retval <<= 8; > > Windows applications make use of the full 32 bits of the return code. > With Emacs it is impossible to know those larger-than-255 exit codes. But not because of the code you cite: the 8-bit left shift just means we can report 24 bits out of 32. And all of that is completely unrelated to GetLastError, because errors in starting the subprocess are not reported via waitpid. Once again, if this is important (I don't think so), we can redefine WEXITSTATUS etc. macros to keep all the 32 bits of the exit status (actually, the top 2 bits are reserved, so only 30 bits can be used). Feel free to submit patches to that effect if you like.