From: Eli Zaretskii <eliz@gnu.org>
To: "Clément Pit--Claudel" <clement.pit@gmail.com>
Cc: acm@muc.de, emacs-devel@gnu.org, schwab@suse.de
Subject: Re: What makes set-window-buffer slow?
Date: Fri, 24 Jun 2016 16:56:47 +0300 [thread overview]
Message-ID: <83shw21yhs.fsf@gnu.org> (raw)
In-Reply-To: <576D2895.4020600@gmail.com> (message from Clément Pit--Claudel on Fri, 24 Jun 2016 08:33:25 -0400)
> Cc: acm@muc.de, schwab@suse.de, emacs-devel@gnu.org
> From: Clément Pit--Claudel <clement.pit@gmail.com>
> Date: Fri, 24 Jun 2016 08:33:25 -0400
>
> >> On 2016-06-23 15:11, Eli Zaretskii wrote:
> >>> Instead of hypothesizing, I suggest to profile your code with
> >>> profiler.el. If indeed redisplay is taking the time, you should
> >>> see that in the profile.
> >>
> >> The profile doesn't show that, unfortunately; in fact, we spent a
> >> significant amount of time trying to understand what was taking all
> >> that time by looking at the profile, but nothing in there was
> >> taking more than 30% of the time, and even optimizing away a
> >> function that according to the profile took 28% of the time didn't
> >> yield a measurable runtime difference.
> >>
> >> Commenting out the call to set-window-buffer (or predicating it on
> >> the window not already displaying the buffer), on the other hand,
> >> does yield a 95% performance gain. set-window-buffer does not
> >> appear in the profile; redisplay_internal does appear, but it only
> >> is credited with 30% of the execution time.
> >>
> >> I wonder what might explain these results...
> >
> > Any hope of seeing the profile, fully expanded?
>
> Absolutely. I've attached it.
Looks like redisplay is indeed an important factor here.
In addition, it looks like you have some subprocess from which you
read input? What's the part of profile below about?
- scomint-output-filter 173 26%
- run-hook-with-args 173 26%
- proof-shell-filter-wrapper 169 26%
- byte-code 169 26%
- proof-shell-filter 160 24%
- proof-shell-filter-manage-output 137 21%
- proof-shell-exec-loop 123 19%
- mapc 95 14%
- proof-shell-invoke-callback 93 14%
- byte-code 93 14%
- proof-done-advancing 93 14%
Can you write some high-level overview of what the inner loop of your
code does, including what is being redisplayed, and how input from
subprocesses enters the picture?
In addition, I suggest to run your benchmark several times, so as to
eliminate the significant portion of time execute-extended-command and
its subroutines, and the profiler itself, show in the profile? Also,
load all the Lisp libraries as *.el files, so that the profile is more
detailed.
next prev parent reply other threads:[~2016-06-24 13:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 15:48 What makes set-window-buffer slow? Clément Pit--Claudel
2016-06-23 16:01 ` Andreas Schwab
2016-06-23 17:45 ` Clément Pit--Claudel
2016-06-23 18:12 ` Alan Mackenzie
2016-06-23 18:30 ` Clément Pit--Claudel
2016-06-23 19:11 ` Eli Zaretskii
2016-06-23 21:23 ` Clément Pit--Claudel
2016-06-24 6:54 ` Eli Zaretskii
2016-06-24 12:33 ` Clément Pit--Claudel
2016-06-24 13:56 ` Eli Zaretskii [this message]
2016-06-24 14:19 ` Clément Pit--Claudel
2016-06-24 18:31 ` Clément Pit--Claudel
2016-06-24 19:13 ` Eli Zaretskii
2016-06-24 21:33 ` Clément Pit--Claudel
2016-06-25 7:30 ` Eli Zaretskii
2016-06-25 14:07 ` Clément Pit--Claudel
2016-06-25 14:27 ` Eli Zaretskii
2016-06-25 14:39 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83shw21yhs.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=acm@muc.de \
--cc=clement.pit@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.