From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23993: [PATCH] Fix cursor display (bug#23993) Date: Sat, 16 Jul 2016 09:54:53 +0300 Message-ID: <83shva5ayq.fsf@gnu.org> References: <8D3C599E-055D-4118-A00F-ED3612D318C0@gmail.com> <20160715201555.GA93647@breton.holly.idiocy.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1468652185 10191 80.91.229.3 (16 Jul 2016 06:56:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Jul 2016 06:56:25 +0000 (UTC) Cc: david.reitter@gmail.com, 23993@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 16 08:56:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bOJWH-00051m-BV for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jul 2016 08:56:13 +0200 Original-Received: from localhost ([::1]:36199 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOJWG-0000QP-Gz for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jul 2016 02:56:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOJWA-0000QJ-5o for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2016 02:56:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bOJW5-000307-Ub for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2016 02:56:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOJW5-000303-RI for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2016 02:56:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bOJW5-0000GD-JS for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2016 02:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jul 2016 06:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23993-submit@debbugs.gnu.org id=B23993.1468652112942 (code B ref 23993); Sat, 16 Jul 2016 06:56:01 +0000 Original-Received: (at 23993) by debbugs.gnu.org; 16 Jul 2016 06:55:12 +0000 Original-Received: from localhost ([127.0.0.1]:53448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOJVH-0000F7-Rg for submit@debbugs.gnu.org; Sat, 16 Jul 2016 02:55:12 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOJVH-0000Ev-6i for 23993@debbugs.gnu.org; Sat, 16 Jul 2016 02:55:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bOJV8-0002iK-R2 for 23993@debbugs.gnu.org; Sat, 16 Jul 2016 02:55:05 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOJV8-0002hz-NK; Sat, 16 Jul 2016 02:55:02 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4161 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bOJV7-0005G4-Ee; Sat, 16 Jul 2016 02:55:02 -0400 In-reply-to: <20160715201555.GA93647@breton.holly.idiocy.org> (message from Alan Third on Fri, 15 Jul 2016 21:15:55 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121136 Archived-At: > Date: Fri, 15 Jul 2016 21:15:55 +0100 > From: Alan Third > Cc: 23993@debbugs.gnu.org, Eli Zaretskii > > --- a/src/xdisp.c > +++ b/src/xdisp.c > @@ -2237,7 +2237,7 @@ get_phys_cursor_geometry (struct window *w, struct glyph_row *row, > ascent = row->ascent; > if (row->ascent < glyph->ascent) > { > - y =- glyph->ascent - row->ascent; > + y -= glyph->ascent - row->ascent; > ascent = glyph->ascent; > } > > -- > Eli, I just wanted to run this by you because you wrote this code and > I'm not sure if that =- is just a typo or it's something I've never > seen before. My guess is it's a typo and gcc happily treats it as -=, > but clang handles it more like 'y = y - a - b' resulting in odd > behaviour on OS X. It's a typo, thanks for catching it.