From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Patches for Emacs 25.2 Date: Tue, 18 Oct 2016 14:29:00 +0300 Message-ID: <83shrtx5dv.fsf@gnu.org> References: <877f96t9oc.fsf@gmx.de> <837f96xgp5.fsf@gnu.org> <87zim2rtck.fsf@gmx.de> <9181f38b-8d6c-c61e-90b0-d44a9e048c9e@gmail.com> <87wph6qd1d.fsf@gmx.de> <831szexb54.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1476790207 17130 195.159.176.226 (18 Oct 2016 11:30:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Oct 2016 11:30:07 +0000 (UTC) Cc: michael.albinus@gmx.de, emacs-devel@gnu.org To: Nikolay Kudryavtsev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 18 13:30:03 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwSal-0003Sg-G4 for ged-emacs-devel@m.gmane.org; Tue, 18 Oct 2016 13:29:59 +0200 Original-Received: from localhost ([::1]:40593 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwSan-0002eu-Li for ged-emacs-devel@m.gmane.org; Tue, 18 Oct 2016 07:30:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwSaA-0002dr-Qc for emacs-devel@gnu.org; Tue, 18 Oct 2016 07:29:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwSa6-0003P5-SV for emacs-devel@gnu.org; Tue, 18 Oct 2016 07:29:22 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwSa6-0003Oz-P2; Tue, 18 Oct 2016 07:29:18 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4831 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bwSa5-0002cr-Pn; Tue, 18 Oct 2016 07:29:18 -0400 In-reply-to: (message from Nikolay Kudryavtsev on Tue, 18 Oct 2016 14:05:46 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208411 Archived-At: > From: Nikolay Kudryavtsev > Cc: emacs-devel@gnu.org > Date: Tue, 18 Oct 2016 14:05:46 +0300 > > bug#23076 was wishlist, that's true. And it's fixed in 25.1 already. It's just that the fix introduces a separate problem breaking tramp git commits. That problem is NOT a wishlist. As for modified - the largest modified part in that commit is tramp-tests the rest are trivial changes to ob-core.el, vc-hooks.el, gud.el. If it's still too large, we can just take only that new tramp function, vc-git fix part(that depends on it) and use that. Even if the function is broken somehow, it would not break anything that is not already broken(tramp vc git commits). The changeset adds 2 new functions, adds 2 new handlers, and uses these handlers in several files. It also adds a defcustom, which already makes it something other than just a bugfix, because it has clear user-visible changes. The added code will most probably have non-trivial consequences, given what it does and how many problems we had in that area. So I don't really see how you can claim that this changeset is safe for 25.2. Once again, if someone suggests a safer change that fixes the bug without introducing new features, I will consider it for the release branch. But that changeset in its present form is out of the question for emacs-25, and Michael feels the same. Sorry. (People who must have this change can always patch their local Tramp.)