all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>
Cc: michael.albinus@gmx.de, emacs-devel@gnu.org
Subject: Re: Patches for Emacs 25.2
Date: Tue, 18 Oct 2016 14:29:00 +0300	[thread overview]
Message-ID: <83shrtx5dv.fsf@gnu.org> (raw)
In-Reply-To: <e73d2e0f-5500-81ce-687d-1e1c74f3339f@gmail.com> (message from Nikolay Kudryavtsev on Tue, 18 Oct 2016 14:05:46 +0300)

> From: Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Tue, 18 Oct 2016 14:05:46 +0300
> 
> bug#23076 was wishlist, that's true. And it's fixed in 25.1 already. It's just that the fix introduces a separate problem breaking tramp git commits. That problem is NOT a wishlist. As for modified - the largest modified part in that commit is tramp-tests the rest are trivial changes to ob-core.el, vc-hooks.el, gud.el. If it's still too large, we can just take only that new tramp function, vc-git fix part(that depends on it) and use that. Even if the function is broken somehow, it would not break anything that is not already broken(tramp vc git commits).

The changeset adds 2 new functions, adds 2 new handlers, and uses
these handlers in several files.  It also adds a defcustom, which
already makes it something other than just a bugfix, because it has
clear user-visible changes.  The added code will most probably have
non-trivial consequences, given what it does and how many problems we
had in that area.

So I don't really see how you can claim that this changeset is safe
for 25.2.

Once again, if someone suggests a safer change that fixes the bug
without introducing new features, I will consider it for the release
branch.  But that changeset in its present form is out of the question
for emacs-25, and Michael feels the same.  Sorry.  (People who must
have this change can always patch their local Tramp.)



  reply	other threads:[~2016-10-18 11:29 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18  7:09 Patches for Emacs 25.2 Michael Albinus
2016-10-18  7:24 ` Eli Zaretskii
2016-10-18  7:47   ` Michael Albinus
2016-10-18  8:09     ` Nikolay Kudryavtsev
2016-10-18  8:25       ` Michael Albinus
2016-10-18  9:24         ` Eli Zaretskii
2016-10-18 11:05           ` Nikolay Kudryavtsev
2016-10-18 11:29             ` Eli Zaretskii [this message]
2016-10-18 11:59               ` Nikolay Kudryavtsev
2016-10-18 12:32                 ` Michael Albinus
2016-10-18 14:38                   ` Eli Zaretskii
2016-11-07  0:08                   ` Dmitry Gutov
2016-11-07  9:01                     ` Michael Albinus
2016-11-07  9:36                       ` Dmitry Gutov
2016-11-07 10:31                         ` Michael Albinus
2016-11-07 10:39                           ` Dmitry Gutov
2016-11-07 10:58                             ` Michael Albinus
2016-11-19 23:03                               ` Dmitry Gutov
2016-11-20 15:34                                 ` file-local-name (was: Patches for Emacs 25.2) Michael Albinus
2016-11-19 23:04                             ` Patches for Emacs 25.2 Dmitry Gutov
2016-11-20  8:49                               ` Michael Albinus
2016-12-31  4:20                               ` Nikolay Kudryavtsev
2016-12-31 11:32                                 ` Dmitry Gutov
2016-12-31 11:40                                   ` Eli Zaretskii
2016-12-31 11:44                                     ` Dmitry Gutov
2017-01-02 10:21                                   ` Nikolay Kudryavtsev
2017-01-02 10:32                                     ` Dmitry Gutov
2017-01-02 12:22                                       ` Michael Albinus
2017-01-02 18:43                                         ` Nikolay Kudryavtsev
2017-01-02 18:54                                           ` Michael Albinus
2017-01-02 19:08                                             ` Dmitry Gutov
2017-01-02 19:56                                               ` Michael Albinus
2017-01-02 20:08                                                 ` Dmitry Gutov
2017-01-02 19:54                                           ` Michael Albinus
2017-01-02 20:52                                             ` Nikolay Kudryavtsev
2017-01-02 19:13                   ` Dmitry Gutov
2016-10-18  9:13     ` Eli Zaretskii
2016-10-18  9:55       ` Michael Albinus
2016-10-18 10:05         ` Eli Zaretskii
2016-10-18 11:24           ` Michael Albinus
2016-10-18 11:30             ` Eli Zaretskii
2016-12-16  0:05 ` Dmitry Gutov
2016-12-16  8:10   ` Eli Zaretskii
2016-12-16 18:33     ` Dmitry Gutov
2016-12-16 21:11       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83shrtx5dv.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    --cc=nikolay.kudryavtsev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.