From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: When should ralloc.c be used? Date: Mon, 24 Oct 2016 20:05:34 +0300 Message-ID: <83shrl3cf5.fsf@gnu.org> References: <87eg3rvtsf.fsf@users.sourceforge.net> <83k2dihpm9.fsf@gnu.org> <8760p2wzgj.fsf@users.sourceforge.net> <838ttyhhzu.fsf@gnu.org> <871szqwu51.fsf@users.sourceforge.net> <831szqhbc2.fsf@gnu.org> <87d1itt79z.fsf_-_@users.sourceforge.net> <7baa18d4-2b09-caa8-005e-29008a383ad1@cs.ucla.edu> <83mvhwrgd5.fsf@gnu.org> <8539f38f-9a11-44c3-4de7-bb974c96206c@cs.ucla.edu> <8360ojpndr.fsf@gnu.org> <83wpgzo30m.fsf@gnu.org> <5a4bbe6d-08ce-e6c6-39d1-49c9cd6d1ffd@cs.ucla.edu> <83mvhvns9a.fsf@gnu.org> <83d1irnozo.fsf@gnu.org> <83mvhunb0d.fsf@gnu.org> <423fab24-9be6-778c-58c3-29a0b825b8c7@cs.ucla.edu> <83a8du5gy1.fsf@gnu.org> <92ca0bf8-7ad4-a7de-70e5-ddbd6eab9741@cs.ucla.edu> <83zilt3dne.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1477330438 1007 195.159.176.226 (24 Oct 2016 17:33:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Oct 2016 17:33:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 24 19:33:54 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byj81-0006fp-BK for ged-emacs-devel@m.gmane.org; Mon, 24 Oct 2016 19:33:41 +0200 Original-Received: from localhost ([::1]:48488 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byj83-0005RP-LH for ged-emacs-devel@m.gmane.org; Mon, 24 Oct 2016 13:33:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byih7-0006AH-FY for emacs-devel@gnu.org; Mon, 24 Oct 2016 13:05:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byih4-0007aK-9F for emacs-devel@gnu.org; Mon, 24 Oct 2016 13:05:53 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52516) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byih4-0007Zq-6u; Mon, 24 Oct 2016 13:05:50 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3285 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1byih1-0000b1-2b; Mon, 24 Oct 2016 13:05:49 -0400 In-reply-to: (message from Paul Eggert on Mon, 24 Oct 2016 09:54:24 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208732 Archived-At: > Cc: emacs-devel@gnu.org > From: Paul Eggert > Date: Mon, 24 Oct 2016 09:54:24 -0700 > > > . Build with gmalloc but without ralloc. > > This goes back to what we were doing, no? No, we were using the glibc malloc, AFAIK. Or am I missing something? > > . Back-port the HYBRID_MALLOC changes from master. Not sure if the > > patch is simple and safe enough, or whether the result is tested > > well enough to have that on emacs-25. > > This sounds riskier. > > > . Build with gmalloc and use mmap for buffer text allocation. > > This also sounds riskier. I agree with your assessments. > How about the attached patch for emacs-25? Basically, it says "use > ralloc.c only if requested via './configure REL_ALLOC=yes'". LGTM. Should we wait for people to build with REL_ALLOC=no manually, to see if there are any problems, or should we push this right away? > I assume that this patch need not be ported to master, due to > HYBRID_MALLOC. Yes, I think so. Thanks.