From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24956: 26.0.50; On Windows, setting PATH in compilation-environment has no effect Date: Sat, 19 Nov 2016 09:16:41 +0200 Message-ID: <83shqoaqhy.fsf@gnu.org> References: <87wpg383pb.fsf@telefonica.net> <83k2c1esbp.fsf@gnu.org> <83wpg1ce8b.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1479539838 32153 195.159.176.226 (19 Nov 2016 07:17:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 19 Nov 2016 07:17:18 +0000 (UTC) Cc: ofv@wanadoo.es, 24956@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 19 08:17:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7zth-0006ju-H6 for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Nov 2016 08:17:13 +0100 Original-Received: from localhost ([::1]:40331 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7ztg-0007MY-IF for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Nov 2016 02:17:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7ztb-0007MS-4A for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2016 02:17:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7ztW-0000Mh-Ai for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2016 02:17:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47205) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c7ztW-0000MZ-7G for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2016 02:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c7ztV-0005g5-WB for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2016 02:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Nov 2016 07:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 24956-submit@debbugs.gnu.org id=B24956.147953980621789 (code B ref 24956); Sat, 19 Nov 2016 07:17:01 +0000 Original-Received: (at 24956) by debbugs.gnu.org; 19 Nov 2016 07:16:46 +0000 Original-Received: from localhost ([127.0.0.1]:34371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7ztF-0005fN-T8 for submit@debbugs.gnu.org; Sat, 19 Nov 2016 02:16:46 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7ztF-0005f9-Bc for 24956@debbugs.gnu.org; Sat, 19 Nov 2016 02:16:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7zt5-0000FB-7Y for 24956@debbugs.gnu.org; Sat, 19 Nov 2016 02:16:39 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7zt5-0000F5-4r; Sat, 19 Nov 2016 02:16:35 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3356 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c7zt4-0001fn-2h; Sat, 19 Nov 2016 02:16:34 -0500 In-reply-to: (message from Noam Postavsky on Fri, 18 Nov 2016 17:11:22 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125857 Archived-At: > From: Noam Postavsky > Date: Fri, 18 Nov 2016 17:11:22 -0500 > Cc: Óscar Fuentes , 24956@debbugs.gnu.org > > Here is a patch. Thanks. Two comments: . I'd rather have the WINDOWSNT-specific code separate (on w32.c), so perhaps the for-loop you modified could be left intact, and instead we perform an additional pass over Vprocess_environment, after it is already copied, to replace these two variables with their upper-case equivalents, in that special code on w32.c. . If you didn't already, please verify that these 2 variables in the Emacs's own environment are also upcased, because otherwise I think we will hit more such problems.