all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: ofv@wanadoo.es, 24956@debbugs.gnu.org
Subject: bug#24956: 26.0.50; On Windows, setting PATH in compilation-environment has no effect
Date: Sat, 19 Nov 2016 09:16:41 +0200	[thread overview]
Message-ID: <83shqoaqhy.fsf@gnu.org> (raw)
In-Reply-To: <CAM-tV--fCzOsuNBBSDH61OoDCtAUay=cLrnXc7mpagvzML4UYQ@mail.gmail.com> (message from Noam Postavsky on Fri, 18 Nov 2016 17:11:22 -0500)

> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Fri, 18 Nov 2016 17:11:22 -0500
> Cc: Óscar Fuentes <ofv@wanadoo.es>, 24956@debbugs.gnu.org
> 
> Here is a patch.

Thanks.

Two comments:

  . I'd rather have the WINDOWSNT-specific code separate (on w32.c),
    so perhaps the for-loop you modified could be left intact, and
    instead we perform an additional pass over Vprocess_environment,
    after it is already copied, to replace these two variables with
    their upper-case equivalents, in that special code on w32.c.

  . If you didn't already, please verify that these 2 variables in the
    Emacs's own environment are also upcased, because otherwise I
    think we will hit more such problems.





  reply	other threads:[~2016-11-19  7:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16 22:22 bug#24956: 26.0.50; On Windows, setting PATH in compilation-environment has no effect Óscar Fuentes
2016-11-17 17:59 ` Noam Postavsky
2016-11-17 20:59   ` Eli Zaretskii
2016-11-17 21:27     ` Noam Postavsky
2016-11-18  9:46       ` Eli Zaretskii
2016-11-18 22:11         ` Noam Postavsky
2016-11-19  7:16           ` Eli Zaretskii [this message]
2016-11-21 23:19             ` Noam Postavsky
2016-11-22 16:01               ` Eli Zaretskii
2016-11-22 22:35                 ` Noam Postavsky
2016-11-23 16:07                   ` Eli Zaretskii
2016-11-27 20:01                     ` Óscar Fuentes
2016-11-27 20:13                       ` npostavs
2016-11-28 22:53                         ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83shqoaqhy.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=24956@debbugs.gnu.org \
    --cc=npostavs@users.sourceforge.net \
    --cc=ofv@wanadoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.