From: Eli Zaretskii <eliz@gnu.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: czipperz@gmail.com, emacs-devel@gnu.org
Subject: Re: Simplify init_lread() branch and fix comments
Date: Wed, 28 Dec 2016 17:46:49 +0200 [thread overview]
Message-ID: <83shp8ukd2.fsf@gnu.org> (raw)
In-Reply-To: <m2h95ov3iv.fsf@linux-m68k.org> (message from Andreas Schwab on Wed, 28 Dec 2016 09:52:56 +0100)
> From: Andreas Schwab <schwab@linux-m68k.org>
> Date: Wed, 28 Dec 2016 09:52:56 +0100
> Cc: emacs-devel@gnu.org
>
> > diff --git a/src/lread.c b/src/lread.c
> > index 35348f1..23ebc8f 100644
> > --- a/src/lread.c
> > +++ b/src/lread.c
> > @@ -4430,17 +4430,13 @@ load_path_default (void)
> > void
> > init_lread (void)
> > {
> > - /* First, set Vload_path. */
> > -
> > - /* Ignore EMACSLOADPATH when dumping. */
> > -#ifdef CANNOT_DUMP
> > - bool use_loadpath = true;
> > -#else
> > - bool use_loadpath = NILP (Vpurify_flag);
> > -#endif
> > -
> > - if (use_loadpath && egetenv ("EMACSLOADPATH"))
> > + if (
> > +#ifndef CANNOT_DUMP
> > + NILP (Vpurify_flag) &&
> > +#endif
> > + egetenv ("EMACSLOADPATH"))
> > {
>
> That makes it worse, and violates the GNU coding style.
Agreed.
prev parent reply other threads:[~2016-12-28 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 3:01 Simplify init_lread() branch and fix comments Chris Gregory
2016-12-28 8:52 ` Andreas Schwab
2016-12-28 15:46 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83shp8ukd2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=czipperz@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.