all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Richard Copley <rcopley@gmail.com>
Cc: 25875@debbugs.gnu.org
Subject: bug#25875: 26.0.50; Hang logging out of MS-Windows
Date: Mon, 27 Feb 2017 17:36:23 +0200	[thread overview]
Message-ID: <83shmzprwo.fsf@gnu.org> (raw)
In-Reply-To: <CAPM58oizEaMnVxcA088CLFmSr98MBvrfKCDSi5tZTVhE-1=5MQ@mail.gmail.com> (message from Richard Copley on Mon, 27 Feb 2017 08:14:22 +0000)

> From: Richard Copley <rcopley@gmail.com>
> Date: Mon, 27 Feb 2017 08:14:22 +0000
> Cc: Eli Zaretskii <eliz@gnu.org>, 25875@debbugs.gnu.org
> 
> > Here's a quick and dirty attempt.  If I haven't made a mistake, it replaces
> > every relevant call to SendMessage by a call to SendMessageTimeout with a
> > 100ms timeout.
> >
> > --- a/src/w32term.c
> > +++ b/src/w32term.c
> > @@ -537,6 +537,15 @@ x_update_begin (struct frame *f)
> >  }
> >
> >
> > +#undef SendMessage
> > +#define SendMessage DebugSendMessage
> > +
> > +static LRESULT WINAPI
> > +DebugSendMessage (HWND hWnd, UINT Msg, WPARAM wParam, LPARAM lParam)
> > +{
> > +  return SendMessageTimeoutA (hWnd, Msg, wParam, lParam, 0, 100, NULL);
> > +}
> > +
> >  /* Start update of window W.  */
> >
> >  static void
> >
> > Ken
> 
> Sorry Ken, I can't sabotage myself like that, I have work to do.

This could be a misunderstanding: the above change is not supposed to
sabotage anything, it's supposed to be a 100% compatible change for
the current behavior when all threads are running, and also provide a
"fire escape" when the addressee of the message is for some reason
stuck, as we think happens in your scenario.

If you are unwilling to make such a sweeping change, could you at
least replace the call SendMessage in my_show_window with
SendMessageTimeoutA, using the above patch as a template?

TIA





  reply	other threads:[~2017-02-27 15:36 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-25 19:35 bug#25875: 26.0.50; Hang logging out of MS-Windows Richard Copley
2017-02-25 19:41 ` Richard Copley
2017-02-25 20:36   ` Eli Zaretskii
2017-02-25 21:13     ` Richard Copley
2017-02-26 15:47       ` Eli Zaretskii
2017-02-26 18:26         ` Richard Copley
2017-02-25 20:33 ` Eli Zaretskii
2017-02-25 21:07   ` Richard Copley
2017-02-25 21:30     ` Richard Copley
2017-02-25 21:37       ` Richard Copley
2017-02-25 22:02         ` Richard Copley
2017-02-26 15:47           ` Eli Zaretskii
2017-02-26 18:37             ` Richard Copley
2017-02-26 15:44     ` Eli Zaretskii
2017-02-26 18:04       ` Ken Brown
2017-02-26 18:25         ` Eli Zaretskii
2017-02-26 18:58           ` Ken Brown
2017-02-26 19:25             ` Eli Zaretskii
2017-02-26 23:38               ` Ken Brown
2017-02-27  8:14                 ` Richard Copley
2017-02-27 15:36                   ` Eli Zaretskii [this message]
2017-02-27 19:04                     ` Richard Copley
2017-02-27 19:16                       ` Eli Zaretskii
2017-02-27 19:23                         ` Richard Copley
2017-02-27 19:30                           ` Richard Copley
2017-02-27 19:39                             ` Ken Brown
2017-02-27 19:46                               ` Richard Copley
2017-02-27 19:56                                 ` Richard Copley
2017-02-27 20:19                                   ` Ken Brown
2017-02-27 20:27                                 ` Eli Zaretskii
2017-02-27 20:52                                   ` Richard Copley
2017-02-27 20:58                                     ` Eli Zaretskii
2017-02-27 21:09                                       ` Richard Copley
2017-02-28  3:30                                         ` Eli Zaretskii
2017-02-28  6:37                                           ` Richard Copley
2017-02-27 22:37                   ` Ken Brown
2017-02-27 23:03                     ` Richard Copley
2017-02-28  3:35                       ` Eli Zaretskii
2017-02-28  7:21                         ` Richard Copley
2017-02-28 15:36                           ` Eli Zaretskii
2017-02-28 16:40                             ` Ken Brown
2017-02-28 16:44                               ` Eli Zaretskii
2017-02-28 18:59                                 ` Richard Copley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83shmzprwo.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=25875@debbugs.gnu.org \
    --cc=rcopley@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.