From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-26, make check failures, mingw64 Date: Wed, 20 Sep 2017 10:21:06 +0300 Message-ID: <83shfhg7j1.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1505892135 24300 195.159.176.226 (20 Sep 2017 07:22:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 20 Sep 2017 07:22:15 +0000 (UTC) Cc: fabrice.popineau@gmail.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 20 09:22:10 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duZKg-0005xM-VL for ged-emacs-devel@m.gmane.org; Wed, 20 Sep 2017 09:22:07 +0200 Original-Received: from localhost ([::1]:47189 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duZKo-000693-Bz for ged-emacs-devel@m.gmane.org; Wed, 20 Sep 2017 03:22:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duZJv-00066b-4n for emacs-devel@gnu.org; Wed, 20 Sep 2017 03:21:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duZJr-0005tC-SZ for emacs-devel@gnu.org; Wed, 20 Sep 2017 03:21:19 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duZJr-0005sn-Pn; Wed, 20 Sep 2017 03:21:15 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2998 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1duZJr-0002mZ-47; Wed, 20 Sep 2017 03:21:15 -0400 In-reply-to: (message from Paul Eggert on Tue, 19 Sep 2017 12:38:46 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218571 Archived-At: > From: Paul Eggert > Date: Tue, 19 Sep 2017 12:38:46 -0700 > > On 09/19/2017 12:08 PM, Fabrice Popineau wrote: > > Clearly, the timezone is wrongly formatted. > > This is because src/w32.c uses the abbreviation "ZZZ" when a POSIX TZ > abbreviation is not supported by MS-Windows. > > One possible fix would be for src/w32.c to call tzset with a ZZZ...Z > abbreviation, and then to modify tzname[0] afterwards to have a copy of > the POSIX-specified abbreviation. src/w32.c could use enough Zs so that > the tzname[0] created by the MS-Windows library would be long enough and > could be updated in place rather than worrying about our reallocating it. > > If that's too much trouble, another workaround would be to change the > test case so that it is not run on MS-Windows. I just tweaked the test to match what Windows returns in this case. The main purpose of the test, AFAIU, is not to test the correctness of the time-zone translation, and there's nothing wrong in ZZZ given that the "-08" thing is not supported on Windows. The rest of the result is correct, so making non-trivial changes in tzset/tzname sounds too much trouble for very little gain: code should not generally be tweaked to fix failing tests with fictitious values. Thanks.