From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: fabrice.popineau@gmail.com, emacs-devel@gnu.org
Subject: Re: emacs-26, make check failures, mingw64
Date: Wed, 20 Sep 2017 10:21:06 +0300 [thread overview]
Message-ID: <83shfhg7j1.fsf@gnu.org> (raw)
In-Reply-To: <c0ccab2a-4a7a-916a-c13c-c109a1916a0f@cs.ucla.edu> (message from Paul Eggert on Tue, 19 Sep 2017 12:38:46 -0700)
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Tue, 19 Sep 2017 12:38:46 -0700
>
> On 09/19/2017 12:08 PM, Fabrice Popineau wrote:
> > Clearly, the timezone is wrongly formatted.
>
> This is because src/w32.c uses the abbreviation "ZZZ" when a POSIX TZ
> abbreviation is not supported by MS-Windows.
>
> One possible fix would be for src/w32.c to call tzset with a ZZZ...Z
> abbreviation, and then to modify tzname[0] afterwards to have a copy of
> the POSIX-specified abbreviation. src/w32.c could use enough Zs so that
> the tzname[0] created by the MS-Windows library would be long enough and
> could be updated in place rather than worrying about our reallocating it.
>
> If that's too much trouble, another workaround would be to change the
> test case so that it is not run on MS-Windows.
I just tweaked the test to match what Windows returns in this case.
The main purpose of the test, AFAIU, is not to test the correctness of
the time-zone translation, and there's nothing wrong in ZZZ given that
the "-08" thing is not supported on Windows. The rest of the result
is correct, so making non-trivial changes in tzset/tzname sounds too
much trouble for very little gain: code should not generally be
tweaked to fix failing tests with fictitious values.
Thanks.
next prev parent reply other threads:[~2017-09-20 7:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 19:08 emacs-26, make check failures, mingw64 Fabrice Popineau
2017-09-19 19:38 ` Paul Eggert
2017-09-20 7:21 ` Eli Zaretskii [this message]
2017-09-20 7:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83shfhg7j1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=fabrice.popineau@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.