From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 108ce84 2/2: xref--next-error-function: Move xref's window point Date: Wed, 28 Feb 2018 17:28:52 +0200 Message-ID: <83sh9lyvyj.fsf@gnu.org> References: <20180228020456.19376.79157@vcs0.savannah.gnu.org> <20180228020457.59950207B1@vcs0.savannah.gnu.org> <1528a8cd-493c-4219-6eb3-693a28aca5a5@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1519831613 11905 195.159.176.226 (28 Feb 2018 15:26:53 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Feb 2018 15:26:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 28 16:26:48 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1er3d2-0002gB-8t for ged-emacs-devel@m.gmane.org; Wed, 28 Feb 2018 16:26:48 +0100 Original-Received: from localhost ([::1]:45116 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1er3f4-0004Hh-OZ for ged-emacs-devel@m.gmane.org; Wed, 28 Feb 2018 10:28:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1er3ey-0004HT-B0 for emacs-devel@gnu.org; Wed, 28 Feb 2018 10:28:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1er3ev-00046Y-6Q for emacs-devel@gnu.org; Wed, 28 Feb 2018 10:28:48 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59070) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1er3ev-00046P-35; Wed, 28 Feb 2018 10:28:45 -0500 Original-Received: from [176.228.60.248] (port=3421 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1er3eu-0002ZM-G4; Wed, 28 Feb 2018 10:28:44 -0500 In-reply-to: <1528a8cd-493c-4219-6eb3-693a28aca5a5@yandex.ru> (message from Dmitry Gutov on Wed, 28 Feb 2018 04:13:22 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223170 Archived-At: > From: Dmitry Gutov > Date: Wed, 28 Feb 2018 04:13:22 +0200 > > Eli, what would you say about backporting this to emacs-26? > > This change is limited in scope, it fixes annoying "looping" behavior > I've seen in some cases, and it adds window point movement you've asked > for before in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20489#110 > > > branch: master > > commit 108ce84432d597f92637ea74bd0a094224d157de > > Author: Dmitry Gutov > > Commit: Dmitry Gutov > > > > xref--next-error-function: Move xref's window point > > > > * lisp/progmodes/xref.el (xref--next-error-function): Move > > xref's window point if it's visible. When we don't do that, > > navigation can start looping after a while. Sorry, this doesn't tell which problem(s) it attempts to fix, and there are no references to discussions or bug reports that could help me figure that out. Without that, I cannot make up my mind about the importance of this fix.