all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 30559@debbugs.gnu.org
Subject: bug#30559: 26.0.91; grep-use-null-filename-separator customization
Date: Fri, 02 Mar 2018 10:26:00 +0200	[thread overview]
Message-ID: <83sh9ix4rr.fsf@gnu.org> (raw)
In-Reply-To: <87fu5jfm89.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 02 Mar 2018 00:45:27 +0200)

> From: Juri Linkov <juri@linkov.net>
> Cc: 30559@debbugs.gnu.org
> Date: Fri, 02 Mar 2018 00:45:27 +0200
> 
> Sorry, I forgot to do the same for zrgrep.  I already noticed earlier
> that grep-use-null-filename-separator let-binding is missing here,
> but forgot to test this to affirm the necessity to fix zrgrep too.
> So this fix is needed for the release branch.
> 
> Eli, is it OK to push this patch to emacs-26 as well?
> 
> diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el
> index 755c9c7..9b6ebee 100644
> --- a/lisp/progmodes/grep.el
> +++ b/lisp/progmodes/grep.el
> @@ -1184,6 +1184,7 @@ zrgrep
>  	   ;; by `grep-compute-defaults'.
>  	   (grep-find-template nil)
>  	   (grep-find-command nil)
> +	   (grep-use-null-filename-separator nil)
>  	   (grep-host-defaults-alist nil)
>  	   ;; Use for `grep-read-files'
>  	   (grep-files-aliases '(("all" . "* .*")

Yes, but please add a comment there explaining why this is done.  (And
AFAIU, our auto-detect stuff needs fixing, if it must be overridden
like that.)

Thanks.





      reply	other threads:[~2018-03-02  8:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-20 21:04 bug#30559: 26.0.91; grep-use-null-filename-separator customization Juri Linkov
2018-02-21  3:40 ` Eli Zaretskii
2018-03-01 22:45   ` Juri Linkov
2018-03-02  8:26     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sh9ix4rr.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=30559@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.